[Bug 201514] net-mgmt/collectd5 - upstream released version 5.5.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201514

Jason Unovitch <jason.unovitch at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #158964|maintainer-approval?(ports@ |
              Flags|bsdserwis.com)              |
 Attachment #158964|0                           |1
        is obsolete|                            |

--- Comment #26 from Jason Unovitch <jason.unovitch at gmail.com> ---
Created attachment 159449
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=159449&action=edit
collectd5-5.5.0.patch

(In reply to Krzysztof from comment #25)

Krzysztof,
What do you think of this revision?

Changes:
- Make Varnish 4 support compile
- Make SIGROK support work
- Remove the vestiages of /var/lib/collectd
- Alphabetic sort of new options in OPTIONS_DEFINE and OPTIONS_GROUP_INPUT
- Remove duplicate /var/lib and varnish.so entries in pkg-plist

Details on 1-3 above:

1. For Varnish it came down to updating the cflags in patch/configure.ac

++              with_libvarnish_cflags="-I$withval/include/varnish"
 +              with_libvarnish_libs="-L$withval/lib/varnish -lvarnishapi"

2. For SIGROK we need to get glib-2.0 in our CFLAGS with this in the Makefile

+CFLAGS+=      `pkg-config --cflags glib-2.0`

3. For /var/lib/collectd, the Makefile.am made this. There were also duplicate
@dir entries in the pkg-plist for it so that is why didn't break QA

+ install-exec-hook:
+      $(mkinstalldirs) $(DESTDIR)$(localstatedir)/run
+-     $(mkinstalldirs) $(DESTDIR)$(localstatedir)/lib/$(PACKAGE_NAME)
+      $(mkinstalldirs) $(DESTDIR)$(localstatedir)/log

-- 
You are receiving this mail because:
You are the assignee for the bug.