[Bug 193474] security/webshag: some ports improvements.

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193474

Jason E. Hale <jhale at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Triage                |In Discussion
                 CC|                            |jhale at FreeBSD.org
           Assignee|freebsd-ports-bugs at FreeBSD. |jhale at FreeBSD.org
                   |org                         |

--- Comment #2 from Jason E. Hale <jhale at FreeBSD.org> ---
Patch looks fine for the issues that were brought up, but there are other
issues that should have been addressed before this port was added:

- webshag.conf should probably be installed as webshag.conf.sample and use the
@sample keyword in pkg-plist so that edited configs don't get overwritten.
- patch-setup_linux_py uses hard-coded paths for PREFIX and LOCALBASE...this
should be fixed.  You could use %%PREFIX%% and %%LOCALBASE%% in the patch
instead, then use a post-patch replacement.
- Python bytecode should be pre-generated with and without the -O flag (.pyo
and .pyc files) for everything installed in PYTHON_SITELIBDIR so there are no
leftovers.

-- 
You are receiving this mail because:
You are the assignee for the bug.