[Bug 193294] graphics/repng2jpeg [maintainer] better conformity REVISION bump DISTNAME removal (test output included)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193294

John Marino <marino at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marino at FreeBSD.org

--- Comment #2 from John Marino <marino at FreeBSD.org> ---
A)

-COMMENT=    Tool to recompress JPEG/PNG/GIF
+COMMENT=    A small tool to recompress JPEG, PNG, and GIF images

That's not a good change.
You can't start a comment with "A", "The", "An", or the name of the port.
I don't know why you are changing this line at all actually, but at lease
change "A small tool" to "Tool" (who cares if it's small?)

B)
Since you are controlling the source, please increment the version instead of
rerolling the source tarball.  That's a huge faux-pas.  We are supposed to
immediately request to upstreams that re-roll tarballs to stop it and don't do
it anymore.

This isn't a "if you can" request.  if you want to change the source, either
use patches or roll a new tarball with a new version.

If you already published the tarball, you also just broke the port, by the way.
 It won't fetch anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.