[Bug 194393] [PATCH] Mk/Uses/autoreconf.mk, add intltoolize support

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194393

Tijl Coosemans <tijl at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tijl at FreeBSD.org

--- Comment #2 from Tijl Coosemans <tijl at FreeBSD.org> ---
Hi,

A few comments:

- You cannot use post-patch because then port makefiles cannot have a
post-patch target.  In this case I think it's best to remove the entire target.
 It's a real bug that maintainers need to be encouraged to fix upstream, so
it's not good for USES=autoreconf to cover this up for them.

- The mkdir line needs to be removed as well.  The directory can be set in
configure.ac using AC_CONFIG_MACRO_DIR and it's not always m4.  It's
unfortunate that intltoolize does not create this directory like libtoolize
does.  Ports will have to create this in their pre/post-patch or pre-configure
targets if necessary.

- The arguments to intltoolize should be '-c -f' to force replacement of any
existing files.  --automake silences some useful tests such as checking if
configure.ac actually contains IT_PROG_INTLTOOL.

-- 
You are receiving this mail because:
You are the assignee for the bug.