[Bug 194669] [maintainer] centos-6.5 editors/sublime3 update (fix gtk2 dependency, add desktop file)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194669

--- Comment #12 from John Marino <marino at FreeBSD.org> ---
this looks okay, although there are no test logs to confirm.

However, there's an existing issue with do-install target.
e.g. "@${INSTALL_DATA} ${WRKSRC}/Icon/48x48/sublime-text.png
${STAGEDIR}${PREFIX}/share/icons/hicolor/48x48/apps/"

You see that "@" in front of the command?  That suppresses the output and we
don't want output suppressed for install commands. (it is permissible on
${MKDIR} commands but not any others)

At the very least, you need to provide a new patch that strips off all those
"@" symbols from install (and pre/post-install if you use those).


Also, provide the output of these commands:

1) portlint
2) make check-plist
3) make stage-qa

thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.