[Bug 195014] [NEW PORT] games/diaspora: Single and multiplayer space fighter combat game

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195014

--- Comment #22 from John Marino <marino at FreeBSD.org> ---
(In reply to lightside from comment #19)
> What I could offer is another poudriere testport log of current changes for
> FreeBSD 10 amd64 version.

You're not addressing the real concern which is that we want dynamic plists to
be limited to either ports mechanisms (e.g. python's auto plist), ports with
extremely long manifests (5000 - 35000 lines or more), or ports with a zillion
options where it's hard to get a static plist correct with all the
permutations.   This port doesn't fit into those three categories.

I think your main motivation is to ease maintenance of this port for future
versions and that's at direct odds with policy, which doesn't want these
changes to be adjusted for.

But in the end, what you are doing isn't any different than putting PORTSDOCS=*
so I will begrudingly accept this with the following change:

compound commands like 

X    cd ${WRKDIR_DIASPORA} && ${COPYTREE_SHARE} "*.pdf *.rtf README.txt" \
X        ${STAGEDIR}${DOCSDIR}

need to be wrapped in parentheses like

X    (cd ${WRKDIR_DIASPORA} && ${COPYTREE_SHARE} "*.pdf *.rtf README.txt" \
X        ${STAGEDIR}${DOCSDIR})

Fix those and I'll promote it.

-- 
You are receiving this mail because:
You are the assignee for the bug.