[Bug 194825] [PATCH] Make sysutils/mcelog build on DragonFly

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Nov 4 22:24:14 UTC 2014


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194825

Jeremy Chadwick <jdc at koitsu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(jdc at ko |maintainer-feedback+
                   |itsu.org)                   |

--- Comment #2 from Jeremy Chadwick <jdc at koitsu.org> ---
I approve of this patch (updating Makefile and files/patch-Makefile.

One thing I want to make clear here, however: the CFLAGS definition (of -Os -g)
in the software's Makefile is somewhat justified.  If you read the top of that
Makefile, they explain why: it has to do with compiler warning flags catching
certain scenarios only when -Os is in use (compared to just -O2 or -O or stock
defaults).  That's something that needs to be kept in mind going forward.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list