ports/190140: building www/chromium fails

[Tsurutani Naoki]

>Number:         190140
>Category:       ports
>Synopsis:       building www/chromium fails
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 23 13:20:01 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Tsurutani Naoki
>Release:        FreeBSD 8.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD h120.65.226.10.32118.vlan.kuins.net 8.4-STABLE FreeBSD 8.4-STABLE #28 r266560: Fri May 23 07:38:29 JST 2014 turutani at h120.65.226.10.32118.vlan.kuins.net:/usr/local/work/usr/obj/usr/src/sys/POLYMER i386


	
>Description:
	building www/chromium fails.
	
>How-To-Repeat:
	% make
	...
	../../media/cast/rtcp/rtcp.cc: In member function 'bool media::cast::Rtcp::RtpTimestampInSenderTime(int, uint32, base::TimeTicks*) const':
	../../media/cast/rtcp/rtcp.cc:365:32: error: call of overloaded 'abs(int64&)' is ambiguous
	../../media/cast/rtcp/rtcp.cc:365:32: note: candidates are:
	In file included from ../../base/memory/scoped_ptr.h:95:0,
	                 from ../../media/cast/rtcp/rtcp.h:15,
	                 from ../../media/cast/rtcp/rtcp.cc:5:
	/usr/local/lib/gcc47/gcc/i386-portbld-freebsd8.4/4.7.3/include-fixed/stdlib.h:100:6: note: int abs(int)
	In file included from /usr/local/lib/gcc47/include/c++/bits/stl_algo.h:61:0,
	                 from /usr/local/lib/gcc47/include/c++/algorithm:63,
	                 from ../../base/memory/scoped_ptr.h:97,
	                 from ../../media/cast/rtcp/rtcp.h:15,
	                 from ../../media/cast/rtcp/rtcp.cc:5:
	/usr/local/lib/gcc47/include/c++/cstdlib:140:3: note: long int std::abs(long int)
	At global scope:
	cc1plus: warning: unrecognized command line option "-Wno-unknown-warning" [enabled by default]
	[3/7497] CXX obj/media/cast/rtcp/cast_rtcp.sender_rtcp_event_subscriber.o
	ninja: build stopped: subcommand failed.
	===> Compilation failed unexpectedly.
	Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
	the maintainer.
	*** Error code 1

	Stop in /usr/ports/www/chromium.
	*** Error code 1

	
>Fix:
	new patch can solve this.

--- media/cast/rtcp/rtcp.cc.orig	2014-05-15 04:23:34.000000000 +0900
+++ media/cast/rtcp/rtcp.cc	2014-05-23 20:04:07.000000000 +0900
@@ -362,7 +362,7 @@
   int64 rtp_time_diff_ms = rtp_timestamp_diff / frequency_khz;
 
   // Sanity check.
-  if (std::abs(rtp_time_diff_ms) > kMaxDiffSinceReceivedRtcpMs)
+  if (std::labs(rtp_time_diff_ms) > kMaxDiffSinceReceivedRtcpMs)
     return false;
 
   *rtp_timestamp_in_ticks = ConvertNtpToTimeTicks(last_received_ntp_seconds_,
	


>Release-Note:
>Audit-Trail:
>Unformatted: