ports/189777: [patch] www/codeigniter staging, change url

[Guido Falsi]

The following reply was made to PR ports/189777; it has been noted by GNATS.

From: Guido Falsi <madpilot at FreeBSD.org>
To: bug-followup at FreeBSD.org, udvzsolt at gmail.com, appleboy.tw at gmail.com
Cc:  
Subject: Re: ports/189777: [patch] www/codeigniter staging, change url
Date: Wed, 14 May 2014 22:51:19 +0200

 While looking at this patch I noticed it has a problem.
 
 The staging conversion is incomplete.
 
 The port is still echoing pkg-message by itself, which is unnecessary
 with staging.
 
 The port also echoes various user message during installation, this is
 wrong when using staging, since thee messages will appear at the wrong
 time, and will never be seen by people using binary packages.
 
 Such messages should be moved to the pkg-message, or, is conditionally
 shown, a pkg-install script should be created to show them if necessary.
 
 Can this patch be fixed keeping all this in mind?
 
 The port is also redefining WWWDIR to it's default value, why is this
 needed?
 
 Thanks in advance.
 
 -- 
 Guido Falsi <madpilot at FreeBSD.org>