ports/188061: [lang/php55] Extensions emit warning DEFAULT_PHP_VER is defined when it's not

[Spil]

>Number:         188061
>Category:       ports
>Synopsis:       [lang/php55] Extensions emit warning DEFAULT_PHP_VER is defined when it's not
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 29 21:30:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Spil
>Release:        10.0-RELEASE
>Organization:
n.a.
>Environment:
FreeBSD build.example.org 10.0-RELEASE FreeBSD 10.0-RELEASE #0: Wed Jan 15 15:26:34 CET 2014     root at build.example.org:/usr/obj/usr/src/sys/BEASTIE100  amd64

>Description:
When building a php 5.5 extension make emits warnings 

/!\ WARNING /!\
DEFAULT_PHP_VER is defined, consider using DEFAULT_VERSIONS=php=55 instead

even when DEFAULT_PHP_VER is not set but it is properly defined using DEFAULT_VERSIONS=       php=5.5
(or DEFAULT_VERSIONS=       php=55)


>How-To-Repeat:
cd /usr/ports/www/php55-opcache
>Fix:
Problem is in Makefile.ext. lang/php55/Makefile contains DEFAULT_VERSIONS= php=55 when PKGNAMESUFFIX is undefined (i.e. not building an extension) but Makefile.ext which it includes when PKGNAMESUFFIX is defined contains DEFAULT_PHP_VER=55 causing the warning. Replacing DEFAULT_PHP_VER in Makefile.ext quenches the error.

--- Makefile.ext.orig   2014-03-29 22:11:26.000000000 +0100
+++ Makefile.ext        2014-03-29 22:09:43.000000000 +0100
@@ -3,7 +3,8 @@
 USE_PHP=       yes
 USE_PHPEXT=    yes
 PHP_MODNAME=   ${PKGNAMESUFFIX:S/-//}
-DEFAULT_PHP_VER=55
+#DEFAULT_PHP_VER=55
+DEFAULT_VERSIONS=       php=55
 IGNORE_WITH_PHP=52 53 54 5

 EXTSUBDIR=     ${DISTNAME}/ext/${PHP_MODNAME}


>Release-Note:
>Audit-Trail:
>Unformatted: