[Bug 191547] New: Flag PKG_ADD_USE_UPGRADE_SCRIPTS have never be set in pkgng

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191547

            Bug ID: 191547
           Summary: Flag PKG_ADD_USE_UPGRADE_SCRIPTS have never be set in
                    pkgng
           Product: Ports Tree
           Version: Latest
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Many People
          Priority: Normal
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs at FreeBSD.org
          Reporter: tuupic at gmail.com

This bug about pkgng

In pkgng documentation written that exists scripts pre-upgrade, post-upgrade
and upgrade (https://wiki.freebsd.org/pkgng#Scripts)
But those scripts can not be run.
Because they enables via flag PKG_ADD_USE_UPGRADE_SCRIPTS

libpkg/pkg_add.c:
============================
        if ((flags & PKG_ADD_NOSCRIPT) == 0) {
                if ((flags & PKG_ADD_USE_UPGRADE_SCRIPTS) ==
PKG_ADD_USE_UPGRADE_SCRIPTS)
                        pkg_script_run(pkg, PKG_SCRIPT_POST_UPGRADE);
                else
                        pkg_script_run(pkg, PKG_SCRIPT_POST_INSTALL);
        }
============================

But this flag never be set

============================
[root at srv5 /usr/ports/ports-mgmt/pkg]# grep -R PKG_ADD_USE_UPGRADE_SCRIPTS
work/
work/pkg-1.2.7/libpkg/pkg.h.in:#define PKG_ADD_USE_UPGRADE_SCRIPTS      (1U <<
1)
work/pkg-1.2.7/libpkg/pkg_add.c:        if ((flags & (PKG_ADD_NOSCRIPT |
PKG_ADD_USE_UPGRADE_SCRIPTS)) == 0)
work/pkg-1.2.7/libpkg/pkg_add.c:                if ((flags &
PKG_ADD_USE_UPGRADE_SCRIPTS) == PKG_ADD_USE_UPGRADE_SCRIPTS)
[root at srv5 /usr/ports/ports-mgmt/pkg]#
============================


So scripts pre-upgrade, post-upgrade, upgrade are broken.

-- 
You are receiving this mail because:
You are the assignee for the bug.