[Bug 195716] [new port] java/GCViewer: classic little tool for java garbage collector log analysis

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195716

Pawel Pekala <pawel at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pawel at FreeBSD.org

--- Comment #2 from Pawel Pekala <pawel at FreeBSD.org> ---
Few ideas for improvement:

- port tries to fetch files during build phase, this is forbidden:

http://people.freebsd.org/~pawel/buildlogs/GCViewer-1.34-10amd64.log

- lines in Makefile should be broken around 80 characters for easier reading

XPORTNAME=    GCViewer

Please don't use capital letters in port names.

X#!/bin/sh
X#
X# $FreeBSD$
X
XJAVA_VERSION="%%JAVA_VERSION%%" "%%LOCALBASE%%/bin/java" -jar
"%%JAVAJARDIR%%/gcviewer.jar" "$@"

Use exec, please see:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-sh-exec.html

-- 
You are receiving this mail because:
You are the assignee for the bug.