[Bug 194944] [New port]: databases/hyperleveldb

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194944

Pawel Pekala <pawel at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pawel at FreeBSD.org

--- Comment #3 from Pawel Pekala <pawel at FreeBSD.org> ---
Few things needs to be fixed:

- Overall Makefile declaration order needs reordering, after LICENSE, there
should be GITHUB_* block, then USE_ variables, on the end options declarations,
see other ports for correct ordering

- Lines should be broken around 80 characters for easier reading

> .include <bsd.port.options.mk>

Not needed, you do have any options dependent logic later

>        ${FIND} ${FIND_FILES}  | ${XARGS} -0 ${REINPLACE_CMD} -e 's|leveldb|hyperleveldb|g'
        ${FIND} ${FIND_FILES}  | ${XARGS} -0 ${REINPLACE_CMD} -e
>'s|hyperhyperleveldb|hyperlev

This could be converted in one find execution and reinplace_cmd with two -e
arguments. Making things simple is always better.

Usually post-patch targets silent their output with leading @ also.

> @dir include/hyperleveldb

Not needed, pkg handles automatically directories with files in them,
see /usr/ports/CHANGES entry 20140922 for details.

-- 
You are receiving this mail because:
You are the assignee for the bug.