[Bug 195014] [NEW PORT] games/diaspora: Single and multiplayer space fighter combat game

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195014

lightside <lightside at gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149580|0                           |1
        is obsolete|                            |

--- Comment #29 from lightside <lightside at gmx.com> ---
Created attachment 150544
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=150544&action=edit
The port in shar format

Hello, Jan Beich.

(In reply to Jan Beich from comment #27)
> CCbyNCSA3 spelling is more common under games/
It's more common to use CC BY-NC-SA 3.0:
http://creativecommons.org/licenses/by-nc-sa/3.0/deed
or CC BY NC SA:
http://en.unesco.org/open-access/terms-use-ccbyncsa-en
I use capital chars for port's licenses (except for (v)ersion, to distinguish
it, as for GPLv2, etc.). Not sure why others started to do otherwise. It's ok
in my case and on the following image:
https://licensebuttons.net/l/by-nc-sa/3.0/88x31.png
The BY here means Attribution, this is not just an adverb or preposition.

(In reply to Jan Beich from comment #27)
> Use SPEECH_CONFIGURE_ENABLE=speech unless --disable-speech is broken.
It's disabled by default for configure, but ok.

(In reply to Jan Beich from comment #27)
> Nowadays, pkg-delete(8) removes empty dirs under PREFIX automatically
> but even before that PORTDATA added @dirrm recursively.

The PORTDATA and current stage capabilities doesn't use empty directories, but
warning about them on stage-qa (make check-plist), if they exists and not added
to package list.

(In reply to Jan Beich from comment #28)
> Ah, reading comment 12 the Makefile should probably explain "why" instead of "what":
>  # Keep empty dirs to help with system-wide customization

I added the "required" word. This is "what" and "why" in the same time:
# Add required empty directories to TMPPLIST

(In reply to Jan Beich from comment #27)
> Can you leverage option helpers?
> Why not replace with PLIST_FILES ?
> Can you include a comment about origin of the patch?

Ok, done.

Thanks for review.

-- 
You are receiving this mail because:
You are the assignee for the bug.