[Bug 195014] [NEW PORT] games/diaspora: Single and multiplayer space fighter combat game

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195014

--- Comment #27 from Jan Beich <jbeich at vfemail.net> ---
Comment on attachment 149580
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=149580
The port in shar format

The port quality is already good but there're a few minor nits:

>XLICENSE_NAME_CCBYNCSAv3=	Creative Commons Attribution-NonCommercial-ShareAlike 3.0 Unported license

CCbyNCSA3 spelling is more common under games/.

>XSPEECH_CONFIGURE_ON=	--enable-speech

Use SPEECH_CONFIGURE_ENABLE=speech unless --disable-speech is broken.

>X.if ${PORT_OPTIONS:MINCJOYBTNS}
>XEXTRA_PATCHES=	${FILESDIR}/extra-patch-increase_joy_buttons_fixed.patch
>X.endif

Can you leverage option helpers?

 
INCJOYBTNS_EXTRA_PATCHES=${FILESDIR}/extra-patch-increase_joy_buttons_fixed.patch

>Xpost-install:
>X# Add empty directories to TMPPLIST
>X	(cd ${STAGEDIR}${DATADIR} && ${FIND} data -type d -empty | ${SORT} |\
>X		${XARGS} -L 1 -I '{}' ${ECHO_CMD} "@dir ${DATADIR}/{}"\
>X		>> ${TMPPLIST})

Nowadays, pkg-delete(8) removes empty dirs under PREFIX automatically
but even before that PORTDATA added @dirrm recursively.

One may want @dir the game doesn't run without *some* empty
directories or if some of the data is mutable (games group) but cannot
live under /var/games.

>X.if ${PORT_OPTIONS:MWXLAUNCHER}
>X# Create a symbolic link and add it to TMPPLIST, which used by launcher
>X	${LN} -sf ${PREFIX}/libexec/fs2_open_${PORTNAME} ${STAGEDIR}${DATADIR}

Why ${LN} line here and not under do-install? It's perfectly legal to
make links to non-existing files. /etc/malloc.conf is notorious example.

>X	${ECHO_CMD} ${DATADIR}/fs2_open_${PORTNAME} >> ${TMPPLIST}

Why not replace with PLIST_FILES ?

>sed 's/^X//' >diaspora/files/extra-patch-increase_joy_buttons_fixed.patch << 'd26dbe503c4133ddd5e224c46d369bc0'
>XIndex: code/controlconfig/controlsconfigcommon.cpp
>X===================================================================
>X--- code/controlconfig/controlsconfigcommon.cpp	(revision 8781)
>X+++ code/controlconfig/controlsconfigcommon.cpp	(working copy)

Can you include a comment about origin of the patch? It may help track
upstreaming state for the next maintainer.

-- 
You are receiving this mail because:
You are the assignee for the bug.