[Bug 186056] New port: databases/cassandra2 The latest stable release of Apache Cassandra

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=186056

John Marino <marino at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Open                        |Patch Ready

--- Comment #8 from John Marino <marino at FreeBSD.org> ---
I sometimes feel very strict when I insist on logs, but when I see new
submissions prior to the log attachment, I feel better. :)

I was going to move this to patch-ready, but I see some immediate minor issues.


MUST BE FIXED:
1) in the post-install and do-install targets, you precede all commands with
"@".  This suppresses the output and it is not allowed (with an exception made
for mkdir commands)

2) It looks like tab alignment is all over the place.  Use tabs=8 spaces

3) PORTDOCS is defined unconditionally.  Remove the PORT_OPTIONS:MDOCS
condition around it.  staging takes care of this.  (see
https://www.freebsd.org/doc/en/books/porters-handbook/install.html#install-documentation
)

4) Remove post-install target, not necessary anymore (done automatically)


NOT STRICTLY NECESSSARY BUT FIX IT ANYWAY
A) Convert this to OPTIONS_SUB=yes to remove the need for PLIST_SUB
https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html

B) use <OPT>_RUN_DEPENDS and <OPT>_USES (see same page above)



Thanks!  sorry about that, but either you fix it or a committer has to.

-- 
You are receiving this mail because:
You are the assignee for the bug.