[Bug 192964] [New Port] devel/go-hashicorp-logutils

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192964

John Marino <marino at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marino at FreeBSD.org

--- Comment #5 from John Marino <marino at FreeBSD.org> ---
(In reply to Thomas Bartelmess from comment #4)
> For me it seems like 
> bsd.port.pre.mk has to be included before bsd.go.mk
> If it's not included, I am getting an error, because the $ARCH variable is
> not set
> 
>    WARNING (devel/go-hashicorp-logutils): make:
> "/usr/ports/devel/go-hashicorp-logutils/../../lang/go/files/bsd.go.mk" line
> 20: Malformed conditional (${ARCH} == "i386")
>    WARNING (devel/go-hashicorp-logutils): make: Fatal errors encountered --
> cannot continue


crap, bsd.go.mk is what needs it.


> 
> 
> Is there a reason why 
> 
> .include "${.CURDIR}/../../lang/go/files/bsd.go.mk"
> 
> if preferred over
> .include "${PORTSDIR}/lang/go/files/bsd.go.mk"


One good reason is that it eliminates the need for <pre> and <post> normally. 
A second reason is that the absolute path fails in some use cases, relative
paths never fail.

Still make this relative patch, but leave <pre>/<post> with a "#" comment
saying that bsd.go.mk has $ARCH requiring <pre> inclusion first.

-- 
You are receiving this mail because:
You are the assignee for the bug.