[Bug 192828] [new port] add squid34 to ports

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192828

--- Comment #30 from Dennis Glatting <freebsd at pki2.com> ---
(In reply to timp87 from comment #29)
> (In reply to John Marino from comment #28)
> > (In reply to takefu from comment #25)
> > > (In reply to timp87 from comment #24)
> > > Kerberos-related is corrupt. 
> > > Especially in the clang is mad 'common'. 
> > > Wait for the fix in the upstream.
> > 
> > I thought we are waiting for upstream as takefu said, "wait".
> > 
> > I'm actually fine with waiting until 15 September.
> > If we put it in before, we have to call it www/squid34 and then move it to
> > www/squid after www/squid is removed.
> > 
> > We can't call it www/squid *NOW* because there's a port there.
> 
> Ok, understood.
> I hope the upstream knows about that problem at least.
> takefu, do you have any additional info?
> 
> Dennis Glatting, I looked at patches that you provided for initial version
> of this port. Sorry, if I ask stupid questions, but:
> 
> Are all of them still valid for 3.4.6?
> For example, is files/patch-src_base_Vector.h still valid? There was a
> similar fix included in 3.4.3
> http://www.squid-cache.org/Versions/v3/3.4/changesets/squid-3.4-13082.patch

3.4.6 compiles without patch-src_base_Vector.h whereas 3.4.2 does not. 
3.4.6 includes (integrated) 13082.patch whereas my version of 3.4.2 did not. If
memory serves, it wasn't available at the time.

Without running the code I conclude patch-src_base_Vector.h is no longer valid.
I'm installing the non-patch-src_base_Vector.h code now for test, before
coffee.

-- 
You are receiving this mail because:
You are the assignee for the bug.