[Bug 192878] comms/pr [maintainer] new source location

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192878

--- Comment #14 from C Hutchinson <portmaster at bsdforge.com> ---
(In reply to John Marino from comment #13)
> (In reply to C Hutchinson from comment #12)
> > Well. I'm stumped.
> > Using your example verbatim, and in every other possible variance,
> > the build fails with:
> > 
> > "Makefile", line 33: Missing dependency operator
> 
> attach your working version of the makefile so I can see it (not shar, just
> upload it as it is)
> 
> 
> > 
> > for all three lines (33, 34, 35).
> > I've also copied blocks that use your same technique, out of other
> > ports. But same results. I've also used examples out of the porters
> > handbook. Same results. Altho, you will probably be happy to know
> > I've changed the DOC install block to something you'd probably
> > approve of:
> > 
> > .if !defined(NOPORTDOCS)
> > 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
> > 	cd ${WRKSRC}/share/doc/pr && ${INSTALL_DATA} ${DOCS} ${STAGEDIR}${DOCSDIR}
> > .endif
> 
> 
> 
> unfortunately NOPORTDOCS is deprecated.  portlint should complain.
> Just define OPTIONS_DEFINE=DOCS and use PORT_OPTIONS:MDOCS, there a thousand
> examples in ports
Yep, and a couple of them are mine. :)
> 
> 
> > 
> > There are no problems with that, at least. But that's all that
> > works.
> > 
> > FWIW I tried this, and several variations:
> > 
> > (cd ${WRKSRC}/sbin && ${INSTALL_SCRIPT} ${PROGRAMS} ${STAGEDIR}${PREFIX})
> > 
> > I had to use INSTALL_SCRIPT to avoid strip(1) being called against
> > ${PROGRAMS}. Which are simply Perl scripts.
> 
> INSTALL_SCRIPT is correct in this case
I also tried COPYTREE_BIN
> 
> 
> > 
> > I used:
> > 
> > (cd ${WRKSRC}/etc && ${INSTALL_DATA} ${ETCFILES} ${STAGEDIR}${PREFIX})
> > 
> > for the .conf, and rc(8) files. But same results.
> > OH well.
> 
> I suspect the error message you get isn't for these lines, but something
> else.  I don't see anything wrong them them.

Here goes...

PORTNAME=    pr
PORTVERSION=    1.1
CATEGORIES=    comms net
MASTER_SITES=    http://bsdforge.com/projects/source/comms/pr/
DISTNAME=    pr-${PORTVERSION}

MAINTAINER=    portmaster at bsdforge.com
COMMENT=    Daemon that connects local terminal device to a terminal server

LICENSE=    ARTPERL10

USE_XZ=        yes

OPTIONS_DEFINE=    DOCS
DOCS=        PR.html

WRKSRC=        ${WRKDIR}/${PORTNAME}

PROGRAMS=    PortRedirector PortTest

ETCFLS=        PortRedirector.conf.sample

RCDFILES=    pr.sh.sample

NO_BUILD=    YES

# doesn't work
do-install:
(cd ${WRKSRC}/sbin && ${INSTALL_SCRIPT} ${PROGRAMS} ${STAGEDIR}${PREFIX})
(cd ${WRKSRC}/etc/rc.d && ${INSTALL_DATA} ${RCDFILES} ${STAGEDIR}${PREFIX})
(cd ${WRKSRC}/etc && ${INSTALL_DATA} ${ETCFLS} ${STAGEDIR}${PREFIX})
# does work
.if ${PORT_OPTIONS:MDOCS}
    @${MKDIR} ${STAGEDIR}${DOCSDIR}
    cd ${WRKSRC}/share/doc/pr && ${INSTALL_DATA} ${DOCS} ${STAGEDIR}${DOCSDIR}
.endif

.include <bsd.port.mk>

Thanks for your reply, John. :)

--Chris

-- 
You are receiving this mail because:
You are the assignee for the bug.