[Bug 192878] comms/pr [maintainer] new source location

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192878

--- Comment #4 from John Marino <marino at FreeBSD.org> ---
In my 10-second review, I only spotted one set of things I'd change (besides
the USES= not be 2-tabbed)

+do-install:
+.for P in ${PROGRAMS}
+    ${CP} ${WRKSRC}/sbin/$P ${STAGEDIR}${PREFIX}/sbin
+.endfor
+.for C in ${ETCFILES} 
+    ${CP} ${WRKSRC}/etc/$C ${STAGEDIR}${PREFIX}/etc
+.endfor
+.for R in ${RCDFILES}
+    ${CP} ${WRKSRC}/etc/rc.d/$R ${STAGEDIR}${PREFIX}/etc/rc.d
+.endfor
+
+.for D in ${DOCFILES}
+    @${MKDIR} ${STAGEDIR}${DOCSDIR}
+    ${INSTALL_DATA} ${WRKSRC}/share/doc/pr/$D ${STAGEDIR}${DOCSDIR}
+.endfor


problem 1) You use $CP instead of $INSTALL_ macros

problen 2) See the top 3 loops?  
The don't need to exist at all.  For example, the first one should be:
(cd ${WRKSRC}/sbin && ${INSTALL_PROGRAM} ${PROGRAMS} ${STAGEDIR}${PREFIX}

problem 3)
you create the DOCSDIR directory once per file.  It's inside the loop!!
and you don't need a loop either (see problem 2)
You need to check ${PORT_OPTIONS:MDOC}


also, portlint did not complain about ${CP}?  or you didn't run portlint?

-- 
You are receiving this mail because:
You are the assignee for the bug.