[Bug 190283] [stage] Add staging support to www/moodle24

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=190283

--- Comment #9 from John Marino <marino at FreeBSD.org> ---
That's good but I see several issues.

#1) your commands in the install targets are masked with "@".  This is against
policy (even if it was there before)

#2) wen@ isn't the maintainer, so it means your patch wasn't generated against
the latest tree.

#3) there's no point to a pre-install and do-install target.  They should be
combined to a single "do-install" target.

That's just a 5-second review

-- 
You are receiving this mail because:
You are the assignee for the bug.