[Bug 192587] [NEW PORT] www/sams2: web-based Squid account management system

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192587

--- Comment #6 from John Marino <marino at FreeBSD.org> ---
These warnings need to be fixed:

Warning: 'bin/samsparser' is not stripped consider using ${STRIP_CMD}
Warning: 'bin/sams2daemon' is not stripped consider using ${STRIP_CMD}
Warning: 'bin/sams2redir' is not stripped consider using ${STRIP_CMD}
Warning: 'lib/sams2/libloadavg.so.1' is not stripped consider using
${STRIP_CMD}
Warning: 'lib/sams2/libfsusage.so.1' is not stripped consider using
${STRIP_CMD}
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
====>> Checking for staging violations... done


If it's an automake file, it may have "install-strip" target.  If you define
"INSTALL_TARGET= install-strip" in that case, the warnings will go away.


the version "2" is part of the packagename already.  So your package name right
now is "sams2-2.0" which is redundant.  There is no sams 1, so there's nothing
to get confused with.  It's perfectly normal to keep the same port name and
increase the versions.

So I think you should go back to calling this "sams" unless there truly is no
upgrade path from sams-1 to sams-2


Anyway, you are very close.  Fix those stage-qa warnings and thing about
renaming it, then I think it will be patch-ready.

-- 
You are receiving this mail because:
You are the assignee for the bug.