ports/189119: [patch] x11/gnome-terminal: link against libICE

Tue Apr 29 18:50:02 UTC 2014

>Number:         189119
>Category:       ports
>Synopsis:       [patch] x11/gnome-terminal: link against libICE
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 29 18:50:01 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Jia-Shiun Li
>Release:        11.0-CURRENT
>Organization:
>Environment:
FreeBSD 4cbsd 11.0-CURRENT FreeBSD 11.0-CURRENT #31 r264726: Tue Apr 22 01:19:28 CST 2014     jsli at 4cbsd:/usr/obj/usr/src/sys/Minimal  amd64
>Description:
gnome-terminal failed compilation finding symbols from libICE after recent update.


>How-To-Repeat:
jsli at 4cbsd:/usr/ports/x11/gnome-terminal.orig # time make -DBATCH
...
...
Generating and caching the translation database
libtool: link: cc -I/usr/local/include/vte-0.0 -I/usr/local/include/gtk-2.0 -I/usr/local/include/gio-unix-2.0/ -I/usr/local/include/atk-1.0-I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/libpng15 -I/usr/local/include/pango-1.0 -I/usr/local/include/freetype2 -I/usr/local/include/harfbuzz -I/usr/local/include/gconf/2 -I/usr/local/include/orbit-2.0 -DORBIT2=1 -pthread -I/usr/local/include/glib-2.0 -D_THREAD_SAFE -I/usr/local/include -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith-Wno-sign-compare -I/usr/local/include -O2 -pipe -fno-strict-aliasing -o gnome-terminal gnome_terminal-eggshell.o gnome_terminal-profile-editor.o gnome_terminal-terminal.o gnome_terminal-terminal-accels.o gnome_terminal-terminal-app.o gnome_terminal-terminal-debug.o gnome_terminal-terminal-encoding.o gnome_terminal-terminal-info-bar.o gnome_terminal-terminal-options.o gnome_terminal-terminal-profile.o gnome_terminal-terminal-screen.o g
 nome_terminal-terminal-screen-container.o gnome_terminal-terminal-search-dialog.o gnome_terminal-terminal-tab-label.o gnome_terminal-terminal-tabs-menu.o gnome_terminal-terminal-util.o gnome_terminal-terminal-window.o gnome_terminal-skey-popup.o gnome_terminal-eggsmclient.o gnome_terminal-eggdesktopfile.o gnome_terminal-eggsmclient-xsmp.o gnome_terminal-terminal-marshal.o gnome_terminal-terminal-type-builtins.o -pthread  -L/usr/local/lib skey/.libs/libskey.a /usr/local/lib/libvte.so /usr/local/lib/libgtk-x11-2.0.so /usr/local/lib/libgdk-x11-2.0.so /usr/local/lib/libharfbuzz.so /usr/local/lib/libpixman-1.so /usr/local/lib/libxcb-shm.so /usr/local/lib/libxcb-render.so /usr/local/lib/libxcb.so /usr/local/lib/libXau.so /usr/local/lib/libXdmcp.so /usr/local/lib/libpthread-stubs.so /usr/local/lib/libpangocairo-1.0.so /usr/local/lib/libXext.so /usr/local/lib/libXrender.so /usr/local/lib/libXinerama.so /usr/local/lib/libXi.so /usr/local/lib/libXrandr.so /usr/local/lib/libXcursor.so /usr/loc
 al/lib/libXcomposite.so /usr/local/lib/libXd!
 amage.so /usr/local/lib/libXfixes.so /usr/local/lib/libatk-1.0.so /usr/local/lib/libcairo.so /usr/local/lib/libgdk_pixbuf-2.0.so /usr/local/lib/libpangoft2-1.0.so /usr/local/lib/libpango-1.0.so /usr/local/lib/libfontconfig.so /usr/local/lib/libexpat.so /usr/local/lib/libfreetype.so /usr/local/lib/libgconf-2.so /usr/local/lib/libgio-2.0.so /usr/local/lib/libORBit-2.so /usr/local/lib/libgmodule-2.0.so /usr/local/lib/libgthread-2.0.so /usr/local/lib/libgobject-2.0.so /usr/local/lib/libffi.so /usr/local/lib/libglib-2.0.so /usr/local/lib/libiconv.so /usr/local/lib/libpcre.so /usr/local/lib/libintl.so /usr/local/lib/libX11.so /usr/local/lib/libSM.so -lutil -lrpcsvc -lgraphite2 -lpng15 -lm -lbz2 -lz -pthread -Wl,-rpath -Wl,/usr/local/lib -Wl,-rpath -Wl,/usr/local/lib
/usr/bin/ld: /usr/local/lib/libICE.so.6: invalid DSO for symbol `IceProcessMessages' definition
/usr/local/lib/libICE.so.6: could not read symbols: Bad value
cc: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[5]: *** [gnome-terminal] Error 1
gmake[5]: *** Waiting for unfinished jobs....
Merging translations into gnome-terminal.schemas.
gmake[5]: Leaving directory `/usr/ports/x11/gnome-terminal.orig/work/gnome-terminal-2.32.1/src'
gmake[4]: *** [all-recursive] Error 1
gmake[4]: Leaving directory `/usr/ports/x11/gnome-terminal.orig/work/gnome-terminal-2.32.1/src'
gmake[3]: *** [all] Error 2
gmake[3]: Leaving directory `/usr/ports/x11/gnome-terminal.orig/work/gnome-terminal-2.32.1/src'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/x11/gnome-terminal.orig/work/gnome-terminal-2.32.1'
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory `/usr/ports/x11/gnome-terminal.orig/work/gnome-terminal-2.32.1'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/x11/gnome-terminal.orig
12.775u 3.969s 0:21.26 78.6%    21076+292k 1265+147io 694pf+0w
jsli at 4cbsd:/usr/ports/x11/gnome-terminal.orig #

>Fix:
looks similar to the problem described in ports/189015 for sysutils/brasero, and with minor change to the original patch reapplied to gnome-terminal, build succeeds.

patch attached.

Patch attached with submission follows:

--- gnome-terminal.orig/Makefile	2014-04-11 18:07:23.000000000 +0800
+++ gnome-terminal/Makefile	2014-04-29 16:22:00.000000000 +0800
@@ -16,7 +16,7 @@
 
 USES=		gettext gmake libtool pathfix pkgconfig tar:bzip2
 INSTALLS_OMF=	yes
-USE_XORG=	sm
+USE_XORG=	ice sm
 USE_GNOME=	gnomeprefix intlhack gconf2 vte gnomedocutils libgnome
 GNU_CONFIGURE=	yes
 CPPFLAGS+=	-I${LOCALBASE}/include
@@ -27,5 +27,8 @@
 post-patch:
 	@${TOUCH} ${WRKSRC}/aclocal.m4 ${WRKSRC}/Makefile.in \
 		${WRKSRC}/configure ${WRKSRC}/config.h.in
+	@${REINPLACE_CMD} -e '/SMCLIENT_LIBS =/s/$$/ -lICE/' \
+		${WRKSRC}/src/Makefile.in
+
 
 .include <bsd.port.mk>


>Release-Note:
>Audit-Trail:
>Unformatted:
