ports/189019: mail/exim: Perl is always needed for build

[Tim Bishop]

>Number:         189019
>Category:       ports
>Synopsis:       mail/exim: Perl is always needed for build
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 26 13:30:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Tim Bishop
>Release:        stable/9
>Organization:
>Environment:
9.2-STABLE
>Description:
I'm building mail/exim without the EMBEDDED_PERL option, and in my poudriere builds this means that perl isn't included. During the build I see:

===>  Configuring for exim-4.82
/bin/sh scripts/source_checks
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found
scripts/source_checks: perl: not found

>How-To-Repeat:
Build mail/exim without the EMBEDDED_PERL option, which is on by default.
>Fix:
This would probably be sufficient, but could do with a bit more testing and verification from the maintainer.

Index: Makefile
===================================================================
--- Makefile    (revision 352256)
+++ Makefile    (working copy)
@@ -19,6 +19,7 @@
 USE_BZIP2=     yes
 WANT_GNOME=    yes
 MAKE_JOBS_UNSAFE=      yes
+USES+=         perl5

 NO_STAGE=      yes
 # One can tune the following "hidden" knobs:
@@ -221,7 +222,6 @@
 .endif

 .if ${PORT_OPTIONS:MEMBEDDED_PERL}
-USES+=         perl5
 SEDLIST+=      -e 's,^\# (EXIM_PERL=),\1,'
 .endif


>Release-Note:
>Audit-Trail:
>Unformatted:
 >>> Creating links to source files...
 
 
 And more similar stuff later on. Then scripts are being installed with #! lines looking like this:
 
 % head -1 /usr/local/sbin/eximstats
 #! -w
 
 Which should be using perl.
 
 The Makefile also has the following in do-configure:
 
         @${REINPLACE_CMD} -E -e 's/^(PERL_COMMAND=).*/\1${PERL:S,/,\/,g}/' \
                 -e 's/^(CC=).*/\1${CC:S,/,\/,g}/' ${WRKSRC}/OS/Makefile-Default
 
 And I'm expecting (but haven't verified) that ${PERL} is only available when USES perl5 is enabled.
 
 So it looks to me like perl should at the very least be a build dependency so that the configure and build stages work, but probably needs to be a runtime dependency too for things like eximstats?