ports/188903: Port "mail/dcc-dccd" fails to build if using sendmail from ports (fix included)

[Jamie Landeg-Jones]

>Number:         188903
>Category:       ports
>Synopsis:       Port "mail/dcc-dccd" fails to build if using sendmail from ports (fix included)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 23 03:20:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Jamie Landeg-Jones
>Release:        FreeBSD 10.0-STABLE amd64
>Organization:
>Environment:
System: FreeBSD catnip.dyslexicfish.net 10.0-STABLE FreeBSD 10.0-STABLE #0: Wed Jan 22 09:10:20 GMT 2014 root at catflap.dyslexicfish.net:/usr/obj/usr/src/sys/CATFLAP amd64


	
>Description:
	

/usr/local/include from CPPFLAGS is not added to CFLAGS, causing
the build to fail, as it can't find included "${LOCALBASE}/libmilter/mfapi.h"
 
The environment and the failure output is included below.

 | cd /usr/scratch/root/usr/ports/mail/dcc-dccd/work/dcc-1.3.141
 | export TMPDIR="/temp/root"
 | export SHELL=/bin/sh
 | export NO_LINT=YES
 | export PREFIX=/usr/local
 | export LOCALBASE=/usr/local
 | export LIBDIR="/usr/lib"
 | export CC="cc"
 | export CFLAGS="-O2 -pipe -mtune=nocona -march=nocona -march=nocona -fno-strict-aliasing -I/usr/local/include"
 | export CFLAGS="-O2 -pipe -mtune=nocona -march=nocona -march=nocona -fno-strict-aliasing"
 | export CPP="cpp"
 | export CPPFLAGS="-I/usr/local/include"
 | export LDFLAGS=" -L/usr/local/lib"
 | export CXX="c++"
 | export CXXFLAGS="-O2 -pipe -mtune=nocona -march=nocona -march=nocona -fno-strict-aliasing"
 | export MANPREFIX="/usr/local"
 | export BSD_INSTALL_PROGRAM="install -s -o root -g wheel -m 555"
 | export BSD_INSTALL_LIB="install -s -o root -g wheel -m 444"
 | export BSD_INSTALL_SCRIPT="install -o root -g wheel -m 555"
 | export BSD_INSTALL_DATA="install -o root -g wheel -m 444"
 | export BSD_INSTALL_MAN="install -o root -g wheel -m 444"
 | /usr/bin/make -f Makefile -j1 all

 | ===> dccm (all)
 | cc -O2 -pipe -mtune=nocona -march=nocona -march=nocona -fno-strict-aliasing -mtune=nocona -march=nocona -march=nocona -I../thrlib   -I../include  -DNDEBUG -g -std=gnu99 -Qunused-arguments  -fstack-protector  -c dccm.c
 | dccm.c:41:10: fatal error: 'libmilter/mfapi.h' file not found
 | #include "libmilter/mfapi.h"
 |          ^
 | 1 error generated.
 | *** [dccm.o] Error code 1
 | 
 | make[3]: stopped in /usr/scratch/root/usr/ports/mail/dcc-dccd/work/dcc-1.3.141/dccm
 | 1 error
 | 
 | make[3]: stopped in /usr/scratch/root/usr/ports/mail/dcc-dccd/work/dcc-1.3.141/dccm
 | *** [all] Error code 2
 | 
 | make[2]: stopped in /usr/scratch/root/usr/ports/mail/dcc-dccd/work/dcc-1.3.141
 | 1 error
 | 
 | make[2]: stopped in /usr/scratch/root/usr/ports/mail/dcc-dccd/work/dcc-1.3.141
 | ===> Compilation failed unexpectedly.
 | Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
 | the maintainer.
 | *** Error code 1
 | 
 | Stop.
 | make[1]: stopped in /usr/ports/mail/dcc-dccd
 | *** Error code 1
 | 
 | Stop.
 | make: stopped in /usr/ports/mail/dcc-dccd
 |              



>How-To-Repeat:
Try to install mail/dcc-dccd on a machine with no base sendmail,
but with sendmail from ports.

	
>Fix:
It seems to be that the makefile within the dccm does not honour CPPFLAGS.

A fix to expicitly add the include-dir to the ports Makefile is attached,
though you may prefer to alter the build-code within the tarball itself!

Cheers, Jamie

	

--- patch-Makefile begins here ---
*** Makefile.orig	2014-01-22 17:00:46.000000000 +0000
--- Makefile	2014-04-23 03:29:55.000000000 +0100
***************
*** 114,119 ****
--- 114,120 ----
  MILTERLIB=	${MILTERBASE}/lib
  
  CPPFLAGS+=	-I${MILTERINC}
+ CFLAGS+=	-I${MILTERINC}
  LDFLAGS+=	-L${MILTERLIB}
  
  CONFIGURE_ARGS+=	--with-sendmail=yes
--- patch-Makefile ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted:
 <synopsis of the problem (one line)>