ports/181708: commit references a PR

[dfilter service]

The following reply was made to PR ports/181708; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: ports/181708: commit references a PR
Date: Mon, 21 Apr 2014 19:02:21 +0000 (UTC)

 Author: marino
 Date: Mon Apr 21 19:02:18 2014
 New Revision: 351703
 URL: http://svnweb.freebsd.org/changeset/ports/351703
 QAT: https://qat.redports.org/buildarchive/r351703/
 
 Log:
   databases/sqlbuddy: Unbreak and stage
   
   The maintainer actually provided a PR to address the breakage long
   before it was marked broken.  itetcu asked him a valid question: Why
   is sqlbuddy defaulting to sqlite when it is primarily a mysql tool?
   The question was never answered and the PR got thrown back on the heap.
   
   The SQLite component is what is missing.  Let's remove sqlite as an
   option to restore the build and stage while here.  It's bumped because
   of the change in default options.
   
   PR:		ports/181708
   submitted by:	maintainer (Chenguang Li)
   modified by:	marino
   MFH:		2014Q2
 
 Modified:
   head/databases/sqlbuddy/Makefile
 
 Modified: head/databases/sqlbuddy/Makefile
 ==============================================================================
 --- head/databases/sqlbuddy/Makefile	Mon Apr 21 18:46:03 2014	(r351702)
 +++ head/databases/sqlbuddy/Makefile	Mon Apr 21 19:02:18 2014	(r351703)
 @@ -3,6 +3,7 @@
  
  PORTNAME=	sqlbuddy
  PORTVERSION=	1.3.3
 +PORTREVISION=	1
  CATEGORIES=	databases www
  MASTER_SITES=	http://www.sqlbuddy.com/download/
  DISTNAME=	${PORTNAME}_1_3_3
 @@ -10,35 +11,20 @@ DISTNAME=	${PORTNAME}_1_3_3
  MAINTAINER=	horus.li at gmail.com
  COMMENT=	Web based MySQL administration with a set of PHP scripts
  
 -BROKEN=		Fails to check-sanity
 -
  USES=		zip
  NO_BUILD=	yes
  
  WRKSRC=		${WRKDIR}/${PORTNAME}
  
 -USE_PHP=	ctype pcre session
 +USE_PHP=	ctype pcre session mysql
  WANT_PHP_WEB=	yes
  
 -OPTIONS_DEFINE=	MYSQL SQLITE
 -OPTIONS_DEFAULT=	SQLITE
 -
  SUB_FILES=	pkg-message
  
 -NO_STAGE=	yes
 -.include <bsd.port.options.mk>
 -
 -.if ${PORT_OPTIONS:MMYSQL}
 -USE_PHP+=	mysql
 -.endif
 -.if ${PORT_OPTIONS:MSQLITE}
 -USE_PHP+=	sqlite
 -.endif
 -
  pre-everything::
  	@${ECHO_MSG} ""
  	@${ECHO_MSG} "NOTE:"
 -	@${ECHO_MSG} "This port suppose you have already installed one or both of these databases supported, "
 +	@${ECHO_MSG} "This port assumes you have already installed a mysql database, "
  	@${ECHO_MSG} "and you want to use SQL Buddy to manage the server."
  	@${ECHO_MSG} "If you are planning to install it/them on this machine later, "
  	@${ECHO_MSG} "you can find it/them at ${PORTSDIR}/databases."
 @@ -47,9 +33,8 @@ pre-everything::
  do-install:
  	@${ECHO_MSG} ""
  	@${ECHO_MSG} "Installing SQL Buddy under ${WWWDIR}/"
 -	@${MKDIR} ${WWWDIR}
 -	@cd ${WRKSRC} && ${CP} -R * ${WWWDIR}
 -	@${CHOWN} -R ${WWWOWN}:${WWWGRP} ${WWWDIR}
 -	@${CAT} ${PKGMESSAGE}
 +	@${MKDIR} ${STAGEDIR}${WWWDIR}
 +	@cd ${WRKSRC} && ${CP} -R * ${STAGEDIR}${WWWDIR}
 +	@${CHOWN} -R ${WWWOWN}:${WWWGRP} ${STAGEDIR}${WWWDIR}
  
  .include <bsd.port.mk>
 _______________________________________________
 svn-ports-all at freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-ports-all
 To unsubscribe, send any mail to "svn-ports-all-unsubscribe at freebsd.org"