ports/188826: pftop broken on -CURRENT

[Daniel Engberg]

>Number:         188826
>Category:       ports
>Synopsis:       pftop broken on -CURRENT
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr 20 12:10:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Daniel Engberg
>Release:        FreeBSD HEAD (AMD64)
>Organization:
>Environment:
FreeBSD 11.0-CURRENT #3 r264552
>Description:
pftop fails on -CURRENT and have done so for quite a while now...

===>  Building for pftop-0.7_2
--- objwarn ---
--- pftop.o ---
--- objwarn ---
Warning: Object directory not changed from original /usr/ports/sysutils/pftop/work/pftop-0.7
--- pftop.o ---
cc -O2 -pipe -march=core2  -DHAVE_ALTQ=1 -DHAVE_SNPRINTF=1 -DHAVE_VSNPRINTF=1 -DHAVE_FINE_GRAINED_LOCKING=1 -fno-strict-aliasing   -Wall -DOS_LEVEL=45 -std=gnu89 -Qunused-arguments  -fstack-protector  -c pftop.c
--- sf-gencode.o ---
cc -O2 -pipe -march=core2  -DHAVE_ALTQ=1 -DHAVE_SNPRINTF=1 -DHAVE_VSNPRINTF=1 -DHAVE_FINE_GRAINED_LOCKING=1 -fno-strict-aliasing   -Wall -DOS_LEVEL=45 -std=gnu89 -Qunused-arguments  -fstack-protector  -c sf-gencode.c
In file included from sf-gencode.c:49:
./sf-gencode.h:173:20: warning: unknown attribute 'volatile' ignored [-Wattributes]
    __attribute__((volatile, __format__ (printf, 1, 2)));
                   ^
./sf-gencode.h:191:6: error: conflicting types for 'bpf_dump'
void bpf_dump(struct bpf_program *, int);
     ^
/usr/include/pcap/pcap.h:416:6: note: previous declaration is here
void    bpf_dump(const struct bpf_program *, int);
        ^
--- pftop.o ---
In file included from pftop.c:68:
./sf-gencode.h:173:20: warning: unknown attribute 'volatile' ignored [-Wattributes]
    __attribute__((volatile, __format__ (printf, 1, 2)));
                   ^
--- sf-gencode.o ---
sf-gencode.c:1861:37: warning: passing 'char *' to parameter of type 'const u_char *' (aka 'const unsigned char *') converts between pointers to integer types with different sign [-Wpointer-sign]
--- pftop.o ---
./sf-gencode.h:191:6: error: conflicting types for 'bpf_dump'
void bpf_dump(struct bpf_program *, int);
     ^
/usr/include/pcap/pcap.h:416:6: note: previous declaration is here
void    bpf_dump(const struct bpf_program *, int);
        ^
--- sf-gencode.o ---
        b0 = gen_bcmp(off, strlen(ifname), ifname);
                                           ^~~~~~
sf-gencode.c:395:50: note: passing argument to parameter 'v' here
gen_bcmp(u_int offset, u_int size, const u_char *v)
                                                 ^
2 warnings and 1 error generated.
*** [sf-gencode.o] Error code 1

make[1]: stopped in /usr/ports/sysutils/pftop/work/pftop-0.7
--- pftop.o ---
pftop.c:856:41: warning: passing 'char *' to parameter of type 'const u_char *' (aka 'const unsigned char *') converts between pointers to integer types with different sign [-Wpointer-sign]
                        if (bpf_filter(filter_prog.bf_insns, (char *)(&state_buf[n]),
                                                             ^~~~~~~~~~~~~~~~~~~~~~~
/usr/include/pcap/pcap.h:412:57: note: passing argument to parameter here
u_int   bpf_filter(const struct bpf_insn *, const u_char *, u_int, u_int);
                                                          ^
pftop.c:1652:28: warning: incompatible pointer to integer conversion passing 'counter_u64_t' (aka 'unsigned long *') to parameter of type 'u_int64_t' (aka 'unsigned long'); dereference with * [-Wint-conversion]
        print_fld_size(FLD_STATS, pr->states_tot);
                                  ^~~~~~~~~~~~~~
                                  *
./engine.h:112:47: note: passing argument to parameter 'size' here
void print_fld_size(field_def *fld, u_int64_t size);
                                              ^
3 warnings and 1 error generated.
*** [pftop.o] Error code 1

make[1]: stopped in /usr/ports/sysutils/pftop/work/pftop-0.7
2 errors

make[1]: stopped in /usr/ports/sysutils/pftop/work/pftop-0.7
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/sysutils/pftop

>How-To-Repeat:
Build pftop in ports
>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: