ports/188524: sysutils/grub2 and ZFS: missing feature for read 'com.delphix:hole_birth'

[Andrey Zholos]

>Number:         188524
>Category:       ports
>Synopsis:       sysutils/grub2 and ZFS: missing feature for read 'com.delphix:hole_birth'
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 12 17:40:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Andrey Zholos
>Release:        10.0-STABLE
>Organization:
>Environment:
>Description:
I am using GRUB to boot the kernel directly from ZFS.

After running zpool upgrade -a recently, GRUB stopped being able to access the
ZFS filesystem.

>How-To-Repeat:
# grub-probe -d /dev/gpt/mypool
missing feature for read 'com.delphix:hole_birth'
missing feature for read 'com.delphix:hole_birth'
missing feature for read 'com.delphix:hole_birth'
missing feature for read 'com.delphix:hole_birth'
grub-probe: error: unknown filesystem.

>Fix:
Patch to ignore this feature flag attached.

# grub-probe -d /dev/gpt/mypool
zfs

Booting with GRUB also works so far.

However, I'm not certain whether the ZFS reading code in GRUB actually needs to
be updated for this feature flag.


Patch attached with submission follows:

--- sysutils/grub2/files/patch-grub-2.00-zfs-feature-flag-support
+++ sysutils/grub2/files/patch-grub-2.00-zfs-feature-flag-support
@@ -92,7 +92,7 @@
 + * to be listed here since grub opens pools in read-only mode.
 + */
 +static const char *spa_feature_names[] = {
-+	"org.illumos:lz4_compress",NULL
++	"org.illumos:lz4_compress","com.delphix:hole_birth",NULL
 +};
 +
 +static int NESTED_FUNC_ATTR


>Release-Note:
>Audit-Trail:
>Unformatted: