ports/188449: sshguard_pidfile variable not defined

[Alexander Mishin]

>Number:         188449
>Category:       ports
>Synopsis:       sshguard_pidfile variable not defined
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 11 06:20:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Alexander Mishin
>Release:        RELEASE-10.0.0
>Organization:
>Environment:
FreeBSD p501720.domain.com 10.0-RELEASE FreeBSD 10.0-RELEASE #1 r264302: Thu Apr 10 16:00:59 MSK 2014     root at p501720.domain.com:/usr/obj/usr/src/sys/PIGEON  amd64
>Description:
There is no defined variable ${sshguard_pidfile} in service script "/usr/local/etc/rc.d/sshguard after" installed sshguard from ports. Only ${pidfile} is defined. But service script try to use it. 

[root at p501720 /usr/local/etc/rc.d]# grep pidfile -n sshguard 
40:# sshguard_pidfile (str):	Path to PID file.
77:pidfile=${sshguard_pidfile:-"/var/run/${name}.pid"}
84:command_args="-cf ${actual_command} -b ${sshguard_blacklist} ${sshguard_watch_params} -a ${sshguard_safety_thresh} -p ${sshguard_pardon_min_interval} -s ${sshguard_prescribe_interval} -w ${sshguard_whitelistfile} -i ${sshguard_pidfile}"

>How-To-Repeat:
Just install sshguard and check for no sshguard_* vars but sshguard_enable="YES"

#service sshguard start - shows running sshguard but realy do nothing.
>Fix:
Define variable sshguard_pidfile="/var/run/sshguard.pid" in /etc/rc.conf yourself.

Or correct your /usr/local/etc/rc.d/sshguard for:
command_args="-cf ${actual_command} -b ${sshguard_blacklist} ${sshguard_watch_params} -a ${sshguard_safety_thresh} -p ${sshguard_pardon_min_interval} -s ${sshguard_prescribe_interval} -w ${sshguard_whitelistfile} -i ${sshguard_pidfile}"
to:
command_args="-cf ${actual_command} -b ${sshguard_blacklist} ${sshguard_watch_params} -a ${sshguard_safety_thresh} -p ${sshguard_pardon_min_interval} -s ${sshguard_prescribe_interval} -w ${sshguard_whitelistfile} -i ${pidfile}"

>Release-Note:
>Audit-Trail:
>Unformatted: