ports/188285: [lang/php] Unneccesary ZTS/threaded warning WITH_ZTS

[Spil]

>Number:         188285
>Category:       ports
>Synopsis:       [lang/php] Unneccesary ZTS/threaded warning WITH_ZTS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 05 09:50:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Spil
>Release:        FreeBSD 10.0-RELEASE
>Organization:
n.a.
>Environment:
FreeBSD build.example.org 10.0-RELEASE FreeBSD 10.0-RELEASE #0: Wed Jan 15 15:26:34 CET 2014     root at beastie.example.org:/usr/obj/usr/src/sys/BEASTIE100  amd64

>Description:
When building mod_php55 there was an unneccesary warning
!!! If you have a threaded Apache, you must build ${PHP_PORT} with ZTS support to enable thread-safety in extensions !!!
when make is run with (non-default) option ZTS enabled
>How-To-Repeat:
# make showconfig
===> The following configuration options are available for mod_php55-5.5.11:
     AP2FILTER=off: Use Apache 2.x filter interface (experimental)
     DEBUG=off: Enable debug
     DTRACE=off: Enable DTrace support
     IPV6=on: Enable ipv6 support
     MAILHEAD=off: Enable mail header patch
     LINKTHR=on: Link thread lib (for threaded extensions)
     ZTS=on: Force Zend Thread Safety (ZTS) build
===> Use 'make config' to modify these settings
# # make
/!\ WARNING /!\
!!! If you have a threaded Apache, you must build lang/php55 with ZTS support to enable thread-safety in extensions !!!


>Fix:
Add conditional block around the warning that checks the ZTS option (see patch)

Patch attached with submission follows:

--- lang/php5/Makefile.orig	2014-04-04 13:08:17.000000000 +0200
+++ lang/php5/Makefile	2014-04-05 11:32:54.889146154 +0200
@@ -102,8 +102,10 @@
 PKGMESSAGE=	${PKGDIR}/pkg-message.mod
 MODULENAME=	libphp5
 SHORTMODNAME=	php5
+.if ! ${PORT_OPTIONS:MZTS}
 WARNING=	"!!! If you have a threaded Apache, you must build ${PHP_PORT} with ZTS support to enable thread-safety in extensions !!!"
 .endif
+.endif
 
 .if ${PORT_OPTIONS:MEMBED}
 PHP_SAPI+=	embed
--- lang/php55/Makefile.orig	2014-04-05 11:32:15.505149240 +0200
+++ lang/php55/Makefile	2014-04-05 11:30:59.251157567 +0200
@@ -102,8 +102,10 @@
 PKGMESSAGE=	${PKGDIR}/pkg-message.mod
 MODULENAME=	libphp5
 SHORTMODNAME=	php5
+.if ! ${PORT_OPTIONS:MZTS}
 WARNING=	"!!! If you have a threaded Apache, you must build ${PHP_PORT} with ZTS support to enable thread-safety in extensions !!!"
 .endif
+.endif
 
 .if ${PORT_OPTIONS:MEMBED}
 PHP_SAPI+=	embed


>Release-Note:
>Audit-Trail:
>Unformatted: