ports/188163: devel/libedit doesn't compile

[Rodrigo Osorio]

>Number:         188163
>Category:       ports
>Synopsis:       devel/libedit doesn't compile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 01 10:10:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Rodrigo Osorio
>Release:        
>Organization:
>Environment:
>Description:
pm reported by the FreeSWITCH project:
----------------------------------------------------------------------
I am contacting you on behalf of the FreeSWITCH project. We strive to
make FreeSWITCH buildable on FreeBSD and recently started unbundling
several libraries, including libedit. While the system version
under /usr works fine, the version installed from Ports, either from
binary or from source, fails to link during a configure check.

configure:23672: checking for el_line in -ledit
configure:23697: cc -o conftest -g -O2 -Wno-extended-offsetof -I/usr/local/include -L/usr/local/lib conftest.c -ledit  -ljpeg  >&5
/usr/local/lib/libedit.so: undefined reference to `tgetflag'
/usr/local/lib/libedit.so: undefined reference to `tgetent'
/usr/local/lib/libedit.so: undefined reference to `tputs'
/usr/local/lib/libedit.so: undefined reference to `tgoto'
/usr/local/lib/libedit.so: undefined reference to `tgetnum'
/usr/local/lib/libedit.so: undefined reference to `tgetstr'

This is because this version of libedit is not linked to one of
ncurses, tinfo, or termcap, even though libedit's own configure script
checks for these.

/usr/local/lib/libedit.so:
        libc.so.7 => /lib/libc.so.7 (0x80081d000)

/usr/lib/libedit.so:
        libncurses.so.8 => /lib/libncurses.so.8 (0x80162b000)
        libc.so.7 => /lib/libc.so.7 (0x80081d000)

The attached patch fixes the issue. May you please apply it?
---------------------------------------------------------------------

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- Makefile.in.orig	2014-03-31 22:55:39.000000000 +0100
+++ Makefile.in	2014-03-31 22:55:02.000000000 +0100
@@ -178,7 +178,7 @@
 	$(RANLIB) $@
 
 $(LIB_S) : $(BGCSRCS:.c=.o_s) $(CCSRCS:.c=.o_s)
-	$(CC) $(S_LDFLAGS) -o $@ $(BGCSRCS:.c=.o_s) $(CCSRCS:.c=.o_s)
+	$(CC) $(S_LDFLAGS) -o $@ $(BGCSRCS:.c=.o_s) $(CCSRCS:.c=.o_s) $(LIBS)
 
 $(TEST) : $(TCSRCS:.c=.o) $(LIB_A)
 	$(CC) -o $@ $(TCSRCS:.c=.o) $(LIB_A) $(LIBS)


>Release-Note:
>Audit-Trail:
>Unformatted: