ports/182495: net/wizd: svn revision 302141 broke install of port

[Scot W. Hetzel]

>Number:         182495
>Category:       ports
>Synopsis:       net/wizd: svn revision 302141 broke install of port
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 29 20:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Scot W. Hetzel
>Release:        FreeBSD 10.0-ALPHA2 i386
>Organization:
>Environment:
System: FreeBSD fbsd10 10.0-ALPHA2 FreeBSD 10.0-ALPHA2 #0 r255731: Sat Sep 21 08:56:02 CDT 2013 root at fbsd10:/usr/obj/usr/src/sys/GENERIC i386
>Description:
Revison 302141 broke the port when it changed the name of the rc.d script from
wizd.sh to wizd.  This breakage was caused due to the port defines NO_WRKSUBDIR, and builds ${WRKDIR}/wizd.  Then when the port goes to install the rc.d script, USE_SUBR overwrites ${WRKDIR}/wizd with the ${FILEDIR}/wizd.in.

>How-To-Repeat:
Check out revision 302141
cd /usr/ports
svn{,lite} update -r 302141 net/wizd
cd net/wizd

root at fbsd10:/usr/ports/net/wizd # make build
:
root at fbsd10:/usr/ports/net/wizd # file work/wizd
work/wizd: ELF 32-bit LSB executable, Intel 80386, version 1 (FreeBSD), dynamically linked (uses shared libs), for FreeBSD 10.0 (1000055), stripped

root at fbsd10:/usr/ports/net/wizd # make install
===>  Staging for wizd-24_5
===>   wizd-24_5 depends on executable: nkf - found
===>   wizd-24_5 depends on shared library: dvdread - found
===>   wizd-24_5 depends on shared library: jpeg - found
===>   Generating temporary packing list
install  -s -o root -g wheel -m 555 /usr/ports/net/wizd/work/wizd /usr/ports/net/wizd/work/stage/usr/local/bin
strip: /usr/ports/net/wizd/work/stage/usr/local/bin/wizd: File format not recognized
install: wait: No such file or directory
*** Error code 70

Stop.
make: stopped in /usr/ports/net/wizd

root at fbsd10:/usr/ports/net/wizd # file work/wizd
work/wizd: POSIX shell script, ASCII text executable
>Fix:

- Remove NO_WRKSUBDIR
- Change EXTRACT_AFTER_ARGS to extract the sources to WRKSRC
- Update the port to support stage

To restore the port check out revision 323759 and apply the below patch:

--- wizd.diff begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 323759)
+++ Makefile	(working copy)
@@ -19,13 +19,9 @@
 		jpeg:${PORTSDIR}/graphics/jpeg
 RUN_DEPENDS=	nkf:${PORTSDIR}/japanese/nkf
 
-DEPRECATED=	Broken for more than 6 month
-EXPIRATION_DATE=	2013-08-27
-BROKEN=		does not install
-
-NO_WRKSUBDIR=	yes
 USE_DOS2UNIX=	Makefile
 USE_ZIP=	yes
+EXTRACT_AFTER_ARGS=	-d ${WRKSRC}
 USE_RC_SUBR=	wizd
 
 post-patch:
@@ -32,17 +28,17 @@
 	@${REINPLACE_CMD} -e 's|./skin|${DATADIR}/skins|' ${WRKSRC}/wizd.conf
 
 do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/wizd ${PREFIX}/bin
-	${INSTALL_DATA} ${WRKSRC}/wizd.conf ${PREFIX}/etc/wizd.conf.sample
+	${INSTALL_PROGRAM} ${WRKSRC}/wizd ${STAGEDIR}${PREFIX}/bin
+	${INSTALL_DATA} ${WRKSRC}/wizd.conf ${STAGEDIR}${PREFIX}/etc/wizd.conf.sample
 
-	${MKDIR} ${DATADIR}/skins
+	${MKDIR} ${STAGEDIR}${DATADIR}/skins
 .for DIR in simplicity simplicity_hires
-	cd ${WRKSRC} && ${COPYTREE_SHARE} ${DIR} ${DATADIR}/skins
+	cd ${WRKSRC} && ${COPYTREE_SHARE} ${DIR} ${STAGEDIR}${DATADIR}/skins
 .endfor
 
 .if !defined(NOPORTDOCS)
-	${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/ChangeLog.txt ${DOCSDIR}
+	${MKDIR} ${STAGEDIR}${DOCSDIR}
+	${INSTALL_DATA} ${WRKSRC}/ChangeLog.txt ${STAGEDIR}${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>
--- wizd.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: