ports/182097: [patch] unbreak ports/emulators/fmsx

[Eugene Grosbein]

>Number:         182097
>Category:       ports
>Synopsis:       [patch] unbreak ports/emulators/fmsx
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 14 18:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Eugene Grosbein
>Release:        FreeBSD 8.4-STABLE amd64
>Organization:
RDTC JSC
>Environment:
System: FreeBSD eg.sd.rdtc.ru 8.4-STABLE FreeBSD 8.4-STABLE #2 r251830M: Mon Jun 17 18:05:24 NOVT 2013 root at eg.sd.rdtc.ru:/usr/local/obj/usr/local/src/sys/EG amd64

>Description:
	The port emulators/fmsx was marked as BROKEN (does not build) via
	http://svnweb.freebsd.org/ports?view=revision&revision=312817

	In fact, the code does not have any compilation errors, only warnings.
	Real fix for these warnings would require significant redesign
	of some parts of code as original author uses same function
	to return integers sometimes and sometimes in returns pointers to char.
	The code uses casts from pointers to integers and vice versa heavily.
	This is intential.

	Let's suppress these warnings for this legacy code using
	CFLAGS+=-Wno-pointer-to-int-cast -Wno-int-to-pointer-cast
	as it bulds and runs flawlessly then.

	The author of the code is Cc'ed.

>How-To-Repeat:
	See http://svnweb.freebsd.org/ports?view=revision&revision=312817

>Fix:

diff -urN fmsx.orig/Makefile fmsx/Makefile
--- fmsx.orig/Makefile	2013-09-15 01:20:57.000000000 +0700
+++ fmsx/Makefile	2013-09-15 01:20:49.000000000 +0700
@@ -3,7 +3,7 @@
 
 PORTNAME=	fmsx
 PORTVERSION=	3.5.1
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	emulators
 MASTER_SITES=	http://www.mavetju.org/download/adopted/:code \
 		http://fms.komkon.org/fMSX/:code \
@@ -25,8 +25,6 @@
 RESTRICTED=	Legal status of distributed ROM images unclear
 WRKSRC=		${WRKDIR}
 
-BROKEN=		does not build
-
 OPTIONS_DEFINE=	BPP8 BPP16 BPP24 BPP32 DOCS
 OPTIONS_DEFAULT=	BPP32
 BPP8_DESC=	With BPP8
diff -urN fmsx.orig/files/patch-fMSX_Unix_Makefile fmsx/files/patch-fMSX_Unix_Makefile
--- fmsx.orig/files/patch-fMSX_Unix_Makefile	2013-04-06 12:00:33.000000000 +0700
+++ fmsx/files/patch-fMSX_Unix_Makefile	2013-09-15 01:15:28.000000000 +0700
@@ -1,5 +1,14 @@
---- fMSX/Unix/Makefile.orig	2008-01-28 19:29:59.000000000 +0000
-+++ fMSX/Unix/Makefile	2008-05-26 05:52:08.000000000 +0000
+--- fMSX/Unix/Makefile.orig	2008-01-29 02:29:59.000000000 +0700
++++ fMSX/Unix/Makefile	2013-09-15 01:14:44.000000000 +0700
+@@ -1,7 +1,7 @@
+ include ../../EMULib/Rules.Unix
+ 
+ DEFINES+= -DFMSX -DLSB_FIRST -DBPP16 -DCONDEBUG -DDEBUG
+-CFLAGS += -I$(LIBZ80)
++CFLAGS += -I$(LIBZ80) -Wno-pointer-to-int-cast -Wno-int-to-pointer-cast
+ OBJECTS+= $(EMUUNIX) $(FLOPPY) $(FDIDISK) \
+ 	  $(Z80) $(I8255) $(YM2413) $(AY8910) $(SCC) $(WD1793) \
+ 	  ../fMSX.o ../MSX.o ../V9938.o ../I8251.o ../Patch.o \
 @@ -10,7 +10,7 @@
  all:    fmsx
  
>Release-Note:
>Audit-Trail:
>Unformatted: