ports/182085: devel/git-review: drop argparse dependency

Ruslan Makhmatkhanov rm at FreeBSD.org
Sat Sep 14 10:40:01 UTC 2013


>Number:         182085
>Category:       ports
>Synopsis:       devel/git-review: drop argparse dependency
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 14 10:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Ruslan Makhmatkhanov
>Release:        10.0-CURRENT
>Organization:
>Environment:
10.0-CURRENT amd64
>Description:
argparse is a part of python standard library since 2.7 and 3.2. Because python2.6 will be removed soon and python3.1 is deprecated, this dependency should be removed.

While I'm on it, remove excessшму MASTER_SITE_SUBDIR and add trailing slash to WWW.

PS. I'm not reporting argparse issue to apstream, because they removed this dependency in git trunk:

https://github.com/openstack-infra/git-review/blob/master/setup.py
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 327243)
+++ Makefile	(working copy)
@@ -2,9 +2,9 @@
 
 PORTNAME=	git-review
 PORTVERSION=	1.23
+PORTREVISION=	1
 CATEGORIES=	devel python
 MASTER_SITES=	CHEESESHOP
-MASTER_SITE_SUBDIR=	source/g/${PORTNAME}
 
 MAINTAINER=	dereckson at gmail.com
 COMMENT=	Allow to push review and interact with a Gerrit server
@@ -11,8 +11,7 @@
 
 LICENSE=	AL2
 
-RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}argparse>0:${PORTSDIR}/devel/py-argparse \
-		git:${PORTSDIR}/devel/git
+RUN_DEPENDS=	git:${PORTSDIR}/devel/git
 
 USE_PYTHON=	yes
 NO_BUILD=	yes
Index: pkg-descr
===================================================================
--- pkg-descr	(revision 327243)
+++ pkg-descr	(working copy)
@@ -4,4 +4,4 @@
 It allows you to push change to review, download a changeset into a new branch,
 push a change as draft or push an amended change as new patchset.
 
-WWW: https://launchpad.net/git-review
+WWW: https://launchpad.net/git-review/


>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-ports-bugs mailing list