ports/183459: [PATCH] graphics/aqsis: Fix build with OpenEXR 2.0.1 [exp-run]

Rusmir Dusko nemysis at FreeBSD.org
Wed Oct 30 23:17:48 UTC 2013


> Nemysis,
> 
> thanks for your patch. I have a few modifications to it, in particular:
> 
> - I don't like your change of naming convention in ${PATCHDIR}. Double
>   underscores are unneeded and ugly.

I have used // as in this patched file.

> - FLTK is not needed. It's only used in a prototype that is not included
>   in the build process (yet).

Sure.

> - I don't think installing AUTHORS and README is of much use.

I think that users wish this, but what you wish.

> Moreover, can you please elaborate on using shared-mime-info? I'm not
> familiar with that, and I've got this warnings on port test:
> 
> ===> Extra files and directories check  
> share/mime/subclasses
> share/mime/globs
> share/mime/globs2
> share/mime/magic
> share/mime/XMLnamespaces
> share/mime/aliases
> share/mime/types
> share/mime/generic-icons
> share/mime/icons
> share/mime/treemagic
> share/mime/mime.cache
> share/mime/version
> 
> Is this going to be a problem?

No these lefover are mtree and is normal.
 
> A new diff is attached.

I accept this diff and soon commit with all other Ports which need bump port revision after
exp-run for graphics/ilmbase and grahics/OpenEXR update to 2.0.1.


More information about the freebsd-ports-bugs mailing list