ports/183269: mediatomb crashes on video file scan.

[Andriy Syrovenko]

>Number:         183269
>Category:       ports
>Synopsis:       mediatomb crashes on video file scan.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 24 10:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Andriy Syrovenko
>Release:        9.1-RELEASE-p7
>Organization:
>Environment:
FreeBSD fbsd01 9.1-RELEASE-p7 FreeBSD 9.1-RELEASE-p7 #0: Mon Sep  9 21:34:37 UTC 2013     root at amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
After the recent update of multimedia/ffmpeg to v.2.0.1 mediatomb started crashing on any video file scan attempt.

Stack back trace shows avformat_open_input() on top. My investigation showed that avformat_open_input() expects either the AVFormatContext being pre-initialized or a pointer to it being set to NULL. Neither is currently the case in mediatomb.

>How-To-Repeat:
Start mediatomb and add some directory containing video files to scan.

>Fix:
The following patch fixed the problem for me:

Index: net/mediatomb/files/patch-livav9
===================================================================
--- net/mediatomb/files/patch-livav9	(revision 331419)
+++ net/mediatomb/files/patch-livav9	(working copy)
@@ -12,6 +12,15 @@
  		if (tag && tag->value && tag->value[0])
  		{
  			log_debug("Added metadata %s: %s\n", m->avname, tag->value);
+@@ -281,7 +281,7 @@
+     int x = 0;
+     int y = 0;
+
+-	AVFormatContext *pFormatCtx;
++	AVFormatContext *pFormatCtx = 0;
+ 	
+ 	// Suppress all log messages
+ 	av_log_set_callback(FfmpegNoOutputStub);
 @@ -290,14 +290,14 @@
      av_register_all();
  


Patch attached with submission follows:

Index: net/mediatomb/files/patch-livav9
===================================================================
--- net/mediatomb/files/patch-livav9	(revision 331419)
+++ net/mediatomb/files/patch-livav9	(working copy)
@@ -12,6 +12,15 @@
  		if (tag && tag->value && tag->value[0])
  		{
  			log_debug("Added metadata %s: %s\n", m->avname, tag->value);
+@@ -281,7 +281,7 @@
+     int x = 0;
+     int y = 0;
+
+-	AVFormatContext *pFormatCtx;
++	AVFormatContext *pFormatCtx = 0;
+ 	
+ 	// Suppress all log messages
+ 	av_log_set_callback(FfmpegNoOutputStub);
 @@ -290,14 +290,14 @@
      av_register_all();
  


>Release-Note:
>Audit-Trail:
>Unformatted: