ports/183106: [patch] sysutils/libcdio: does not build on 10.0 and HEAD

[Rainer Hurling]

>Number:         183106
>Category:       ports
>Synopsis:       [patch] sysutils/libcdio: does not build on 10.0 and HEAD
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 19 17:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Rainer Hurling
>Release:        11.0-CURRENT amd64 (clang)
>Organization:
>Environment:
FreeBSD xxx.xxx.xxx 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r256766: Sat Oct 19 11:51:54 CEST 2013     xxx at xxx.xxx.xxx:/usr/obj/usr/src/sys/XXX  amd64
>Description:
sysutils/libcdio: After the major changes in CURRENT (e.g. libiconv), the build stops with the following message:

[..snip..]
libtool: link: cc -O2 -pipe -fno-strict-aliasing -Wall -Wchar-subscripts -Wmissing-prototypes -Wmissing-declarations -Wunused -Wpointer-arith -Wwrite-strings -Wnested-externs -Wno-sign-compare -Wl,-rpath=/usr/local/lib -o .libs/cdda-player cdda-player.o cddb.o getopt.o getopt1.o  -L/usr/local/lib ../lib/driver/.libs/libcdio.so /usr/local/lib/libcddb.so -lncurses -lm -lcam -Wl,-rpath -Wl,/usr/local/lib
/usr/bin/ld: ): invalid DSO for symbol `cbreak' definition
/usr/local/lib/libtinfo.so.5.9: could not read symbols: Bad value
cc: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[4]: *** [cdda-player] Fehler 1
gmake[4]: Leaving directory `/usr/ports/sysutils/libcdio/work/libcdio-0.83/src'
gmake[3]: *** [all-recursive] Fehler 1
gmake[3]: Leaving directory `/usr/ports/sysutils/libcdio/work/libcdio-0.83/src'
gmake[2]: *** [all-recursive] Fehler 1
gmake[2]: Leaving directory `/usr/ports/sysutils/libcdio/work/libcdio-0.83'
gmake[1]: *** [all] Fehler 2
gmake[1]: Leaving directory `/usr/ports/sysutils/libcdio/work/libcdio-0.83'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1
Stop.
make: stopped in /usr/ports/sysutils/libcdio

>How-To-Repeat:
Build sysutils/libcdio on recent 10.0 or HEAD.
>Fix:
Adding the complained lib to LDFLAGS seems to solve the problem:

LDFLAGS+=     -ltinfow


Patch attached with submission follows:

--- Makefile.orig	2013-10-04 07:48:38.000000000 +0200
+++ Makefile	2013-10-19 18:59:57.000000000 +0200
@@ -23,7 +23,7 @@
 CONFIGURE_ARGS+=${ICONV_CONFIGURE_ARG}
 USE_PERL5=	build
 CPPFLAGS+=	-I${LOCALBASE}/include
-LDFLAGS+=	-L${LOCALBASE}/lib ${ICONV_LIB}
+LDFLAGS+=	-L${LOCALBASE}/lib ${ICONV_LIB} -ltinfow
 MAN1=	cd-drive.1 cd-info.1 iso-read.1 iso-info.1 cd-read.1
 
 INFO=		libcdio


>Release-Note:
>Audit-Trail:
>Unformatted: