ports/183095: make index fails without perl after wasting significant time

[Niels Endres]

>Number:         183095
>Category:       ports
>Synopsis:       make index fails without perl after wasting significant time
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 19 05:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Niels Endres
>Release:        9.2-RELEASE
>Organization:
>Environment:
FreeBSD beastie 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255898: Thu Sep 26 22:50:31 UTC 2013     root at bake.isc.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
If perl is not installed on a system when running make index in /usr/ports, significant time is spent building the temp index files for each category before the entire process fails.

The supplied patch performs a quick check first that will fail if perl is not in the system path and executable prior to performing the bulk of the work.


>How-To-Repeat:
attempt to make index without perl
>Fix:
Index: Makefile
===================================================================
--- Makefile    (revision 330845)
+++ Makefile    (working copy)
@@ -112,6 +112,7 @@
 #.endif
 
 ${INDEXDIR}/${INDEXFILE}:
+       @perl -e '' || exit 1
        @${INDEX_ECHO_1ST} "Generating ${INDEXFILE} - please wait.."; \
        if [ "${INDEX_PRISTINE}" != "" ]; then \
                export LOCALBASE=/nonexistentlocal; \

>Release-Note:
>Audit-Trail:
>Unformatted: