ports/183026: [PATCH] news/nzbget: cleanup and missing depends

[Mark Felder]

>Number:         183026
>Category:       ports
>Synopsis:       [PATCH] news/nzbget: cleanup and missing depends
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 16 13:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Mark Felder
>Release:        
>Organization:
>Environment:
>Description:
nzbget should really have a default depend on archivers/unrar and an option for archivers/p7zip. Python post processing scripts are also now provided as of 11.0, so Python should be a runtime dependency as well.

Attached patch provides the following:

- General cleanup
- unrar and python are default enabled options
- p7zip option, disabled by default
- The final release of 11.0 only requires --disable-sigchld-handler on 32bit FreeBSD [1]

[1] http://nzbget.sourceforge.net/forum/viewtopic.php?f=3&t=596&start=10


>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 330498)
+++ Makefile	(working copy)
@@ -3,6 +3,7 @@
 
 PORTNAME=	nzbget
 PORTVERSION=	11.0
+PORTREVISION=	1
 CATEGORIES=	news
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}-stable/${PORTVERSION}
 
@@ -23,30 +24,38 @@
 LDFLAGS+=	${PTHREAD_LIBS}
 CFLAGS+=	${PTHREAD_CFLAGS}
 
-OPTIONS_DEFINE=	PAR
+OPTIONS_DEFINE=	7Z PAR PYTHON RAR
 OPTIONS_SINGLE=	TLSLIB
 OPTIONS_SINGLE_TLSLIB=	GNUTLS OPENSSL
-OPTIONS_DEFAULT=	PAR GNUTLS
+OPTIONS_DEFAULT=	GNUTLS PAR PYTHON RAR
+7Z_DESC=	Support extraction of 7z archives
 PAR_DESC=	Support verifying/repairing with par2 files
+PYTHON_DESC=	Support for python post-processing scripts
+RAR_DESC=	Support extraction of rar archives
 
+7Z_RUN_DEPENDS=		7z:${PORTSDIR}/archivers/p7zip
+
 PAR_CONFIGURE_ON=	--enable-parcheck --disable-libpar2-bugfixes-check
 PAR_CONFIGURE_OFF=	--disable-parcheck
 PAR_LIB_DEPENDS=	libpar2.so:${PORTSDIR}/archivers/libpar2
 
+PYTHON_USE=	PYTHON=yes
+
+RAR_RUN_DEPENDS=	unrar:${PORTSDIR}/archivers/unrar
+
 OPENSSL_CONFIGURE_ON=	--with-tlslib=OpenSSL \
 			--with-openssl-includes=${OPENSSLINC} \
 			--with-openssl-libraries=${OPENSSLLIB}
+OPENSSL_USE=	OPENSSL=yes
 
 GNUTLS_CONFIGURE_ON=	--with-tlslib=GnuTLS
 GNUTLS_LIB_DEPENDS=	libgnutls.so:${PORTSDIR}/security/gnutls \
 			libgcrypt.so:${PORTSDIR}/security/libgcrypt
 
-CONFIGURE_ARGS+=	--enable-sigchld-handler
-
 .include <bsd.port.options.mk>
 
-.if ${PORT_OPTIONS:MOPENSSL}
- USE_OPENSSL=	yes
+.if (${ARCH} == "i386")
+CONFIGURE_ARGS+=       --disable-sigchld-handler
 .endif
 
 post-configure:
Index: files/nzbget.in
===================================================================
--- files/nzbget.in	(revision 330498)
+++ files/nzbget.in	(working copy)
@@ -1,5 +1,7 @@
 #!/bin/sh
 #
+# $FreeBSD$
+#
 # PROVIDE: nzbget
 # KEYWORD: shutdown
 #
@@ -11,15 +13,15 @@
 
 . /etc/rc.subr
 
-name="nzbget"
+name=nzbget
 rcvar=nzbget_enable
 
 load_rc_config ${name}
 
-: ${nzbget_enable:="NO"}
+: ${nzbget_enable:=NO}
 
 start_cmd="${name}_start"
-status_cmd="${name}_status"
+status_cmd="${command} status"
 stop_cmd="${name}_stop"
 command=%%PREFIX%%/sbin/nzbgetd
 
@@ -38,9 +40,4 @@
 	${command} stop
 }
 
-nzbget_status()
-{
-	${command} status
-}
-
 run_rc_command "$1"


>Release-Note:
>Audit-Trail:
>Unformatted: