ports/182923: some ports still require WITH_PKGNG=1

[dt71]

>Number:         182923
>Category:       ports
>Synopsis:       some ports still require WITH_PKGNG=1
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 12 14:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     dt71
>Release:        -CURRENT
>Organization:
>Environment:
FreeBSD  11.0-CURRENT FreeBSD 11.0-CURRENT #0 r256311M: Fri Oct 11 16:42:56 CEST 2013     root@:/usr/obj/usr/src/sys/CUSTOM  i386
>Description:
pkgng should be default package management tool on both -CURRENT and 11.0-RELEASE. This means that people who do not want to use pkgng should add WITHOUT_PKGNG=1 to /etc/make.conf (as opposed to: people who do want to use pkgng should add WITH_PKGNG=1). Yet, there are still a few ports that use ".if defined(WITH_PKGNG)" checks in the relevant Makefile; for example, if the system uses pkgng (pkg2ng has been run, or vice versa), then the ports-mgmt/pkg_cutleaves port will not work (the program will not find any packages installed) unless WITH_PKGNG=1 is specified. It is time to change this behavior, ie., the Makefiles in each port directory should be altered to use ".if defined(WITHOUT_PKGNG)" or similar checks.
>How-To-Repeat:
1. Use pkgng.
2. Remove the WITH_PKGNG=1 setting from /etc/make.conf, if present.
3. Build and (re)install ports-mgmt/pkg_cutleaves.
4. Run pkg_cutleaves; notice that the program doesn't find any ports installed.
>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: