ports/182893: multimedia/dv2sub - fix brokenness of package build when clang is CC

[Phil Oleson]

>Number:         182893
>Category:       ports
>Synopsis:       multimedia/dv2sub - fix brokenness of package build when clang is CC
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 11 04:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Phil Oleson
>Release:        FreeBSD 6.4-RELEASE-p8 i386
>Organization:
N/A
>Environment:
System: FreeBSD nixil.net 6.4-RELEASE-p8 FreeBSD 6.4-RELEASE-p8 #1 r101746: Mon Aug 30 10:34:40 MDT 2010 root at fc:/usr/src/sys/i386/compile/VKERN i386


>Description:
	The packages autoconf script can't handle clang.. 

>How-To-Repeat:
	comment out the offending autoconf code.. clang handles the build fine.
>Fix:

	Patch attached. 

--- dv2sub-clang-fixit-patch begins here ---
diff -ruN dv2sub.orig/Makefile dv2sub/Makefile
--- dv2sub.orig/Makefile	2013-10-02 23:58:12.000000000 -0600
+++ dv2sub/Makefile	2013-10-10 21:48:44.000000000 -0600
@@ -1,9 +1,9 @@
 # Created by: Phil Oleson
-# $FreeBSD: head/multimedia/dv2sub/Makefile 327747 2013-09-20 20:57:48Z bapt $
+# $FreeBSD: multimedia/dv2sub/Makefile 327747 2013-09-20 20:57:48Z bapt $
 
 PORTNAME=	dv2sub
 PORTVERSION=	0.3
-PORTREVISION=	4
+PORTREVISION=	5
 CATEGORIES=	multimedia
 MASTER_SITES=	SF
 
@@ -12,6 +12,10 @@
 
 LIB_DEPENDS=	dv.4:${PORTSDIR}/multimedia/libdv
 
+
+USE_AUTOTOOLS=	aclocal autoconf automake
+AUTOMAKE_ARGS=  -a
+
 GNU_CONFIGURE=	yes
 USES=		pkgconfig
 
diff -ruN dv2sub.orig/files/patch-configure.ac dv2sub/files/patch-configure.ac
--- dv2sub.orig/files/patch-configure.ac	1969-12-31 17:00:00.000000000 -0700
+++ dv2sub/files/patch-configure.ac	2013-10-10 15:36:49.000000000 -0600
@@ -0,0 +1,35 @@
+--- configure.ac.orig	2007-03-05 06:26:54.000000000 -0700
++++ configure.ac	2013-10-10 15:19:53.000000000 -0600
+@@ -30,19 +30,19 @@
+ )
+ 
+ dnl Checks for typedefs, structures, and compiler characteristics.
+-AC_MSG_CHECKING([whether compiler accepts some C99 extensions])
+-save_CFLAGS="$CFLAGS"
+-CFLAGS="$C99MODE_FLAG"
+-AC_TRY_COMPILE(,
+-	[void foo(void) { for(int i=0; i<10; i++) {} }],
+-	[AC_MSG_RESULT(yes)],
+-	[c99_fail=1
+-	AC_MSG_RESULT(no)])
+-if test "x$c99_fail" = "x1"
+-then
+-    AC_MSG_ERROR(ANSI/ISO C99 compiler not found or not in this mode!)
+-fi
+-CFLAGS="$save_CFLAGS"
++dnl AC_MSG_CHECKING([whether compiler accepts some C99 extensions])
++dnl save_CFLAGS="$CFLAGS"
++dnl CFLAGS="$C99MODE_FLAG"
++dnl AC_TRY_COMPILE(,
++dnl 	[void foo(void) { for(int i=0; i<10; i++) {} }],
++dnl 	[AC_MSG_RESULT(yes)],
++dnl 	[c99_fail=1
++dnl 	AC_MSG_RESULT(no)])
++dnl if test "x$c99_fail" = "x1"
++dnl then
++dnl     AC_MSG_ERROR(ANSI/ISO C99 compiler not found or not in this mode!)
++dnl fi
++dnl CFLAGS="$save_CFLAGS"
+ 
+ dnl Arrange for large-file support
+ AC_SYS_LARGEFILE
--- dv2sub-clang-fixit-patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: