ports/182693: multimedia/libvpx: wrong file ownership

[Christian Weisgerber]

>Number:         182693
>Category:       ports
>Synopsis:       multimedia/libvpx: wrong file ownership
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 05 15:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Christian Weisgerber
>Release:        FreeBSD 9.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD lorvorc.mips.inka.de 9.2-STABLE FreeBSD 9.2-STABLE #0 r255924: Sat Sep 28 14:16:39 CEST 2013 naddy at lorvorc.mips.inka.de:/usr/obj/usr/src/sys/GENERIC amd64

>Description:

The multimedia/libvpx port installs files that are owned by the
build user rather than ${BINOWN}.

$ ls -l /usr/local/bin | grep naddy
-rwxr-xr-x  1 naddy  wheel      15876 Oct  5 16:35 vp8_scalable_patterns
-rwxr-xr-x  1 naddy  wheel      60658 Oct  5 16:35 vpxdec
-rwxr-xr-x  1 naddy  wheel      67203 Oct  5 16:35 vpxenc

Looking at the tail end of the install log...

[...]
mkdir -p /usr/local/bin/
cp -p vpxdec /usr/local/bin/vpxdec
mkdir -p /usr/local/bin/
cp -p vpxenc /usr/local/bin/vpxenc
mkdir -p /usr/local/bin/
cp -p vp8_scalable_patterns /usr/local/bin/vp8_scalable_patterns

... we see that the install step erroneously uses cp(1) instead of the
INSTALL_* macros.

This affects all files installed by the port.

>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted: