ports/182680: set-get confusion in a patch

Mamoru Iwaki 1wkmmr at gmail.com
Sat Oct 5 11:40:00 UTC 2013


>Number:         182680
>Category:       ports
>Synopsis:       set-get confusion in a patch
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 05 11:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Mamoru Iwaki
>Release:        FreeBSD 9.2-STABLE
>Organization:
>Environment:
>Description:
Re: # $FreeBSD: haed/audio/xoscope/Makefile 326090 2013-09-02 21:16:30Z
bapt $

I have just looked around audio/xoscope, not compiling it yet.  Then, I
found a strange line in files/patch-ser_unix.c, as follows:

34	+#ifdef BSD
35	+    if (tcgetattr(fd, &svbuf) < 0 ) {
36	+#else
37	     if (ioctl(fd, TCSETA, &svbuf) < 0) {
38	+#endif

I wonder tcgetattr(...) in line 35 should be tcsetattr(...).

Cheers

>How-To-Repeat:

>Fix:
I believe that the line 35 of files/patch-ser_unix.c should be 'set' as follows.

35	+    if (tcsetattr(fd, &svbuf) < 0 ) {



>Release-Note:
>Audit-Trail:
>Unformatted:


More information about the freebsd-ports-bugs mailing list