ports/184381: [PATCH] security/bro: Fix pkg-fallout issue

[Craig Leres]

>Number:         184381
>Category:       ports
>Synopsis:       [PATCH] security/bro: Fix pkg-fallout issue
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 30 01:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Craig Leres
>Release:        FreeBSD 9.1-RELEASE amd64
>Organization:
Lawrence Berkeley National Laboratory
>Environment:
System: FreeBSD fun.ee.lbl.gov 9.1-RELEASE FreeBSD 9.1-RELEASE #11 r26: Wed Sep 11 10:30:14 PDT 2013 leres at fun.ee.lbl.gov:/sys/amd64/compile/LBL amd64

	
>Description:
	Apparently pkgng processes pkg-plist differently than the
	older pkg_* tools. It looks like directories that are cleaned
	up with @dirrmtry statements must exist in the stage tree
	prior to "make package" but in this case it's the @exec at
	the end of this ports pkg-plist which runs "broctl install"
	that actually creates directories the at package install
	time. But that never happens when just building the package.

>How-To-Repeat:
	PR report:

	    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/184194

	pkg-fallout reports:

	    [REL - 91amd64-default][security/bro] Failed for bro-2.2 in package
	    [REL - 91i386-default][security/bro] Failed for bro-2.2 in package

>Fix:
	Since the @dirrmtry lines in the pkg-plist are needed, the
	attached patch creates them in the stage directory tree.

	I'm not using pkgng yet so I have no way to test this. I
	am able to test that this change does not break the port
	for 9.1-RELEASE or 8.2-RELEASE.

--- patch.txt begins here ---
--- Makefile.orig	2013-11-23 04:25:30.000000000 -0800
+++ Makefile	2013-11-29 17:25:09.000000000 -0800
@@ -113,6 +113,8 @@
 .if defined(BRO_PREFIX)
 	@${MKDIR} ${PREFIX}
 .endif
+	@${MKDIR} ${STAGEDIR}${PREFIX}/spool/installed-scripts-do-not-touch/auto
+	@${MKDIR} ${STAGEDIR}${PREFIX}/spool/installed-scripts-do-not-touch/site
 .for F in broctl.cfg
 	@${INSTALL_SCRIPT} ${INSTALL_WRKSRC}/aux/broctl/etc/${F} ${STAGEDIR}${PREFIX}/etc/${F}.example
 .endfor
--- patch.txt ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: