ports/177497: Dovecot port startup script breaks onestart functionality

[Nick]

>Number:         177497
>Category:       ports
>Synopsis:       Dovecot port startup script breaks onestart functionality
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 30 09:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Nick
>Release:        9.1
>Organization:
>Environment:
9.1-STABLE FreeBSD 9.1-STABLE #0 r248873
>Description:
mail/dovecot startup script /usr/local/etc/rc.d/dovecot breaks onestart/onestop startup rc functionality.

No script actions will be performed, if dovecot_enable variable doesn't exist in /etc/rc.conf, which cuts out onestart/onestop functionality
>How-To-Repeat:
Set dovecot_enable to "NO" or remove the variable completely from /etc/rc.conf
Invoke:
/usr/local/etc/rc.d/dovecot
Correct output should be (but it is not):
Usage: /usr/local/etc/rc.d/dovecot [fast|force|one|quiet](start|stop|restart|rcvar|status|poll)


>Fix:
Edit the last section of /usr/local/etc/rc.d/dovecot and comment out checkyesno section (not a clean fix, but helps under my usage scenario):

# To start multiple instances of dovecot set dovecot_config to
# a space seperated list of configuration files.
#if checkyesno ${name}_enable; then
	for config in ${dovecot_config}; do
		required_files="${config}"
		command_args="-c ${config}"
		base_dir=$(${command} ${command_args} -a | /usr/bin/awk -F '= ' '/^base_dir =/ { print $2 }')
		pidfile="${base_dir}/master.pid"
		run_rc_command "$1"
	done
#fi


>Release-Note:
>Audit-Trail:
>Unformatted: