ports/177201: french/aster: [PATCH] doesn't build in poudriere, several issues -- fixed

[John Marino]

>Number:         177201
>Category:       ports
>Synopsis:       french/aster: [PATCH] doesn't build in poudriere, several issues -- fixed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 21 15:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     John Marino
>Release:        
>Organization:
>Environment:
>Description:
There are several problems with this port.

1) libmetis.so presence is checked during configure, it must be added to LIB_DEPENDS
2) Then you don't need to add it to RUN_DEPENDS
3) cata_ele.picked, elements, commande directories are no longer generated.  They have to be removed from both pkg-plist and install target
4) The products.py patch *HARD-CODES* a workdir path which breaks build for any non-standard workdir, such as one poudriere defines.
5) asteru is no longer built, remove it from install target and plist

patch attached.

NOTE: there were directories present as STA10.8/fermetur that are not installed.  Maybe they should be?
>How-To-Repeat:
Try to build aster in poudriere.  good luck.
>Fix:


Patch attached with submission follows:

--- Makefile.orig	2013-03-21 14:27:38.093717000 +0000
+++ Makefile
@@ -33,9 +33,9 @@ BUILD_DEPENDS+=	${LOCALBASE}/aster/ASTK/
 		${SHELL_INSTALL_ASTER}:${PORTSDIR}/shells/${SHIADEP}		\
 		${PYNUMPY}
 LIB_DEPENDS+=	hdf5.7:${PORTSDIR}/science/hdf5-18				\
-		med.5:${PORTSDIR}/french/med
+		med.5:${PORTSDIR}/french/med					\
+		metis:${PORTSDIR}/math/metis-edf
 RUN_DEPENDS+=	${PYTHON_SITELIBDIR}/Gnuplot:${PORTSDIR}/math/py-gnuplot	\
-		${LOCALBASE}/bin/onmetis.exe:${PORTSDIR}/math/metis-edf		\
 		${SHELL_INSTALL_ASTER}:${PORTSDIR}/shells/${SHIADEP}		\
 		${LOCALBASE}/aster/ASTK/ASTK_SERV:${PORTSDIR}/cad/astk-serveur
 
@@ -183,9 +183,8 @@ WITH_ED=	vi
 .endif
 
 vaster=		STA${PORTVERSION:R:R}
-INST_DAT=	LICENSE.TERMS astest cata_ele.pickled catalo catapy	\
-		elements materiau
-INST_PY=	bibpyt commande
+INST_DAT=	LICENSE.TERMS astest catalo catapy materiau
+INST_PY=	bibpyt
 INST_SH=	as_run parallel_cp
 DAT2FIX=	astout.export config.txt forma01a.export
 inst_dir=	${PREFIX}/${PORTNAME}/${vaster}
@@ -319,6 +318,9 @@ pre-configure:
 	${PYTHON_CMD} ${PYTHON_LIBDIR}/compileall.py ${WRKSRC}
 	@${PYTHON_CMD} -O ${PYTHON_LIBDIR}/compileall.py ${WRKSRC}
 
+post-patch:
+	${REINPLACE_CMD} -e 's|/usr/ports/french/aster/work|${WRKDIR}|g' ${WRKSRC}/products.py
+
 do-configure:
 	(cd ${CONFIGURE_WRKSRC} && ${PYTHON_CMD} setup.pyo ${DEBUG_FLAGS} test	\
 		| tee ${CONFIGURE_LOG})
@@ -350,8 +352,6 @@ do-build:
 
 do-install:
 	${MKDIR} ${tools_dir} ${inst_dir} ${PREFIX}/${PORTNAME}/bin
-	${INSTALL_PROGRAM} ${WRKSRC}/instdir/${vaster}/asteru ${inst_dir}
-	#${INSTALL_SCRIPT} ${WRKSRC}/instdir/${vaster}/asterd ${inst_dir} # Don't strip!
 	${INSTALL_SCRIPT} ${WRKSRC}/instdir/${vaster}/profile.sh ${inst_dir}
 	${ECHO_CMD} "" >> ${inst_dir}/profile.sh
 	${ECHO_CMD} "HDF5_DISABLE_VERSION_CHECK=1" >> ${inst_dir}/profile.sh
--- pkg-plist.orig	2013-03-21 14:31:23.880558000 +0000
+++ pkg-plist
@@ -1,5 +1,4 @@
 %%ASTERDIR%%/LICENSE.TERMS
-%%ASTERDIR%%/asteru
 %%ASTERDIR%%/astest/adls102a.comm
 %%ASTERDIR%%/astest/adls102a.datg
 %%ASTERDIR%%/astest/adls102a.mail
@@ -11398,7 +11397,6 @@
 %%ASTERDIR%%/bibpyt/Validation/__init__.py
 %%ASTERDIR%%/bibpyt/Validation/__init__.pyc
 %%ASTERDIR%%/bibpyt/Validation/__init__.pyo
-%%ASTERDIR%%/cata_ele.pickled
 %%ASTERDIR%%/catalo/compelem/grandeur_simple__.cata
 %%ASTERDIR%%/catalo/compelem/phenomene_modelisation__.cata
 %%ASTERDIR%%/catalo/compelem/type_maille__.cata
@@ -12364,9 +12362,6 @@
 %%ASTERDIR%%/catapy/commun/c_suivi_ddl.capy
 %%ASTERDIR%%/catapy/commun/c_type_cham_into.capy
 %%ASTERDIR%%/catapy/entete/accas.capy
-%%ASTERDIR%%/commande/cata.py
-%%ASTERDIR%%/commande/cata.pyc
-%%ASTERDIR%%/commande/cata.pyo
 %%ASTERDIR%%/config.txt
 %%ASTERDIR%%/elements
 %%ASTERDIR%%/forma01a.export
@@ -12400,7 +12395,6 @@ aster/config.txt
 %%GRACE%%@unexec rm -f  %D/%%TOOLDIR%%/xmgrace
 @unexec rm -rf  %D/%%TOOLDIR%% 2>&1 >/dev/null || true
 @dirrm %%ASTERDIR%%/materiau
- at dirrm %%ASTERDIR%%/commande
 @dirrm %%ASTERDIR%%/catapy/entete
 @dirrm %%ASTERDIR%%/catapy/commun
 @dirrm %%ASTERDIR%%/catapy/commande


>Release-Note:
>Audit-Trail:
>Unformatted: