ports/179712: [PATCH] x11/lxpanel: Add licenses, docs, fix NLS, take maintainership

nemysis nemysis at gmx.ch
Wed Jun 19 10:20:00 UTC 2013 

>Number:         179712
>Category:       ports
>Synopsis:       [PATCH] x11/lxpanel: Add licenses, docs, fix NLS, take maintainership
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 19 10:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE-p3 amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.1-RELEASE-p3 FreeBSD 9.1-RELEASE-p3 #0: Mon Apr 29 18:27:25 UTC 2013
>Description:

- Take maintainership
- Add licenses (GPLv2, MIT)
- Add docs
- Fix NLS
- Trim pkg-plist

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports)
>How-To-Repeat:

Build log

https://redports.org/buildarchive/20130619092800-20934/

>Fix:

--- lxpanel-0.5.12.patch begins here ---
diff -ruN /usr/ports/x11/lxpanel/Makefile ./Makefile
--- /usr/ports/x11/lxpanel/Makefile	2013-06-18 18:26:39.000000000 +0200
+++ ./Makefile	2013-06-19 11:22:36.000000000 +0200
@@ -4,12 +4,15 @@
 PORTNAME=	lxpanel
 PORTVERSION=	0.5.12
 CATEGORIES=	x11
-MASTER_SITES=	SF/lxde/LXPanel%20%28desktop%20panel%29/LXPanel%20${PORTVERSION}
+MASTER_SITES=	SF/lxde/LXPanel%20%28desktop%20panel%29/LXPanel%20${PORTVERSION}/
 
-MAINTAINER=	ports at FreeBSD.org
+MAINTAINER=	nemysis at gmx.ch
 COMMENT=	Lightweight X11 desktop panel
 
-LIB_DEPENDS=	menu-cache.1:${PORTSDIR}/x11/menu-cache
+LICENSE=	GPLv2 MIT
+LICENSE_COMB=	dual
+
+LIB_DEPENDS=	menu-cache:${PORTSDIR}/x11/menu-cache
 RUN_DEPENDS=	${LOCALBASE}/share/desktop-directories/lxde-audio-video.directory:${PORTSDIR}/x11/lxmenu-data
 
 OPTIONS_DEFINE=	ALSA NLS
@@ -21,7 +24,7 @@
 GNU_CONFIGURE=	yes
 USE_AUTOTOOLS=	automake:env
 CONFIGURE_ARGS=	--prefix=${PREFIX} \
-		--with-plugins=volume,deskno,kbled,xkb,batt\
+		--with-plugins=volume,deskno,kbled,xkb,batt \
 		CPPFLAGS="-I${LOCALBASE}/include" \
 		LDFLAGS="-L${LOCALBASE}/lib"
 CFLAGS+=	-I${WRKSRC}
@@ -29,6 +32,8 @@
 
 MAN1=		lxpanel.1 lxpanelctl.1
 
+PORTDOCS=	AUTHORS README TODO
+
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MALSA}
@@ -41,14 +46,24 @@
 USES+=		gettext
 PLIST_SUB+=	NLS=""
 .else
-CONFIGURE_ARGS+=--disable-nls
 PLIST_SUB+=	NLS="@comment "
 .endif
 
-pre-patch:
-	@${REINPLACE_CMD} -e 's,linux,sys,' \
+post-patch:
+	@${REINPLACE_CMD} -e 's|linux|sys|' \
 		${WRKSRC}/src/plugins/volume/volume-impl.c
-	@${REINPLACE_CMD} -e 's,$$(DATADIRNAME)/locale,share/locale,' \
+	@${REINPLACE_CMD} -e 's|$$(DATADIRNAME)/locale|share/locale|' \
 		${WRKSRC}/po/Makefile.in.in
 
+.if ! ${PORT_OPTIONS:MNLS}
+	@${REINPLACE_CMD} -e 's|po man|man|' \
+		${WRKSRC}/Makefile.in
+.endif
+
+post-install:
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
+.endif
+
 .include <bsd.port.mk>
diff -ruN /usr/ports/x11/lxpanel/pkg-plist ./pkg-plist
--- /usr/ports/x11/lxpanel/pkg-plist	2013-06-02 18:57:12.000000000 +0200
+++ ./pkg-plist	2013-06-19 11:18:42.000000000 +0200
@@ -1,12 +1,73 @@
 bin/lxpanel
 bin/lxpanelctl
+include/lxpanel/plugin.h
 lib/lxpanel/plugins/batt.so
 lib/lxpanel/plugins/deskno.so
 lib/lxpanel/plugins/kbled.so
 lib/lxpanel/plugins/volume.so
 lib/lxpanel/plugins/xkb.so
 libdata/pkgconfig/lxpanel.pc
-include/lxpanel/plugin.h
+%%NLS%%share/locale/af/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/ar/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/be/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/bg/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/bn/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/bn_IN/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/ca/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/cs/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/da/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/de/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/el/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/en_GB/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/es/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/es_VE/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/et/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/eu/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/fa/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/fi/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/fo/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/fr/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/frp/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/gl/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/he/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/hr/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/hu/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/id/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/it/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/ja/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/kk/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/km/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/ko/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/lg/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/lt/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/ml/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/ms/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/nb/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/nl/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/nn/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/pa/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/pl/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/ps/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/pt/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/pt_BR/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/ro/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/ru/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/sk/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/sl/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/sr/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/sr at latin/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/sv/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/te/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/th/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/tr/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/tt_RU/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/ug/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/uk/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/ur/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/ur_PK/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/vi/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/zh_CN/LC_MESSAGES/lxpanel.mo
+%%NLS%%share/locale/zh_TW/LC_MESSAGES/lxpanel.mo
 %%DATADIR%%/images/background.png
 %%DATADIR%%/images/capslock-off.png
 %%DATADIR%%/images/capslock-on.png
@@ -172,105 +233,26 @@
 %%DATADIR%%/xkeyboardconfig/layouts.cfg
 %%DATADIR%%/xkeyboardconfig/models.cfg
 %%DATADIR%%/xkeyboardconfig/toggle.cfg
-%%NLS%%share/locale/af/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/ar/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/be/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/bg/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/bn/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/bn_IN/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/ca/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/cs/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/da/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/de/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/el/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/en_GB/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/es/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/es_VE/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/et/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/eu/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/fa/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/fi/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/fo/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/fr/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/frp/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/gl/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/he/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/hr/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/hu/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/id/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/it/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/ja/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/kk/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/km/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/ko/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/lg/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/lt/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/ml/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/ms/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/nb/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/nl/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/nn/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/pa/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/pl/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/ps/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/pt/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/pt_BR/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/ro/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/ru/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/sk/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/sl/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/sr/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/sr at latin/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/sv/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/te/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/th/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/tr/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/tt_RU/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/ug/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/uk/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/ur/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/ur_PK/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/vi/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/zh_CN/LC_MESSAGES/lxpanel.mo
-%%NLS%%share/locale/zh_TW/LC_MESSAGES/lxpanel.mo
- at dirrm %%DATADIR%%/images/xkb-flags
- at dirrm %%DATADIR%%/images
- at dirrm %%DATADIR%%/profile/default/panels
- at dirrm %%DATADIR%%/profile/default
+ at dirrm %%DATADIR%%/xkeyboardconfig
+ at dirrm %%DATADIR%%/ui
 @dirrm %%DATADIR%%/profile/two_panels/panels
 @dirrm %%DATADIR%%/profile/two_panels
+ at dirrm %%DATADIR%%/profile/default/panels
+ at dirrm %%DATADIR%%/profile/default
 @dirrm %%DATADIR%%/profile
- at dirrm %%DATADIR%%/ui
- at dirrm %%DATADIR%%/xkeyboardconfig
+ at dirrm %%DATADIR%%/images/xkb-flags
+ at dirrm %%DATADIR%%/images
 @dirrm %%DATADIR%%
- at dirrm include/lxpanel
- at dirrmtry share/locale/bn_IN/LC_MESSAGES
- at dirrmtry share/locale/bn_IN
- at dirrmtry share/locale/es_VE/LC_MESSAGES
- at dirrmtry share/locale/es_VE
- at dirrmtry share/locale/fo/LC_MESSAGES
- at dirrmtry share/locale/fo
- at dirrmtry share/locale/frp/LC_MESSAGES
- at dirrmtry share/locale/frp
- at dirrmtry share/locale/kk/LC_MESSAGES
- at dirrmtry share/locale/kk
- at dirrmtry share/locale/km/LC_MESSAGES
- at dirrmtry share/locale/km
- at dirrmtry share/locale/lg/LC_MESSAGES
- at dirrmtry share/locale/lg
- at dirrmtry share/locale/ps/LC_MESSAGES
- at dirrmtry share/locale/ps
- at dirrmtry share/locale/sr at latin/LC_MESSAGES
- at dirrmtry share/locale/sr at latin
- at dirrmtry share/locale/te/LC_MESSAGES
- at dirrmtry share/locale/te
- at dirrmtry share/locale/tt_RU/LC_MESSAGES
- at dirrmtry share/locale/tt_RU
- at dirrmtry share/locale/ug/LC_MESSAGES
- at dirrmtry share/locale/ug
- at dirrmtry share/locale/ur/LC_MESSAGES
- at dirrmtry share/locale/ur
- at dirrmtry share/locale/ur_PK/LC_MESSAGES
- at dirrmtry share/locale/ur_PK
+%%NLS%%@dirrmtry share/locale/ur_PK/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/ur_PK
+%%NLS%%@dirrmtry share/locale/tt_RU/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/tt_RU
+%%NLS%%@dirrmtry share/locale/lg/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/lg
+%%NLS%%@dirrmtry share/locale/frp/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/frp
+%%NLS%%@dirrmtry share/locale/es_VE/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/es_VE
 @dirrmtry lib/lxpanel/plugins
 @dirrmtry lib/lxpanel
+ at dirrmtry include/lxpanel
--- lxpanel-0.5.12.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:

More information about the freebsd-ports-bugs mailing list