ports/179705: [PATCH] audio/ncmpcpp is missing a build time dependency to pkg-config / pkgconf

[Yamagi Burmeister]

>Number:         179705
>Category:       ports
>Synopsis:       [PATCH] audio/ncmpcpp is missing a build time dependency to pkg-config / pkgconf
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 19 07:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Yamagi Burmeister
>Release:        FreeBSD 9.1-STABLE #0 r251643M
>Organization:
>Environment:
FreeBSD rufus.pw-rz.de 9.1-STABLE FreeBSD 9.1-STABLE #0 r251643M: Wed Jun 12 09:41:47 CEST 2013     root at rufus.pw-rz.de:/usr/obj/usr/src/sys/RUFUS  amd64
>Description:
audio/ncmpcpp is missing a build time dependency to pkgconf. Therefor the port failes when build under poudriere. A somewhat more in depth analyzes:

1. Start poudriere build with: poudriere testport -i -j fbsd-91-amd64 -o audio/ncmpcpp

2. pkgconf is not installed since it's not referenced in the ports Makefile:
=======================<phase: build-depends  >============================
===>   ncmpcpp-0.5.10 depends on file: /usr/local/include/fftw3.h - not found
===>    Verifying install for /usr/local/include/fftw3.h in /usr/ports/math/fftw3
===>   Installing existing package /packages/All/fftw3-3.3.3_1.txz
Installing fftw3-3.3.3_1... done
===>   Returning to build of ncmpcpp-0.5.10
===>   ncmpcpp-0.5.10 depends on file: /usr/local/bin/automake-1.12 - not found
===>    Verifying install for /usr/local/bin/automake-1.12 in /usr/ports/devel/automake
===>   Installing existing package /packages/All/automake-1.12.6.txz
Installing automake-1.12.6...Installing autoconf-wrapper-20101119... done
Installing autoconf-2.69...Installing m4-1.4.16_1,1... done
Installing perl-5.14.4...Removing stale symlinks from /usr/bin...
    Skipping /usr/bin/perl
    Skipping /usr/bin/perl5
Done.
Creating various symlinks in /usr/bin...
    Symlinking /usr/local/bin/perl5.14.4 to /usr/bin/perl
    Symlinking /usr/local/bin/perl5.14.4 to /usr/bin/perl5
Done.
Cleaning up /etc/make.conf... Done.
Spamming /etc/make.conf... Done.
Cleaning up /etc/manpath.config... Done.
Spamming /etc/manpath.config... Done.
 done
 done
Installing automake-wrapper-20101119... done
 done
===>   Returning to build of ncmpcpp-0.5.10
===>   ncmpcpp-0.5.10 depends on package: libtool>=2.4 - not found
===>    Verifying install for libtool>=2.4 in /usr/ports/devel/libtool
===>   Installing existing package /packages/All/libtool-2.4.2.txz
Installing libtool-2.4.2... done
===>   Returning to build of ncmpcpp-0.5.10
=========================================================================
=======================<phase: lib-depends    >============================
===>   ncmpcpp-0.5.10 depends on shared library: mpdclient - not found
===>    Verifying install for mpdclient in /usr/ports/audio/libmpdclient
===>   Installing existing package /packages/All/libmpdclient-2.8.txz
Installing libmpdclient-2.8... done
===>   Returning to build of ncmpcpp-0.5.10
===>   ncmpcpp-0.5.10 depends on shared library: fftw3 - found
===>   ncmpcpp-0.5.10 depends on shared library: curl.6 - not found
===>    Verifying install for curl.6 in /usr/ports/ftp/curl
===>   Installing existing package /packages/All/curl-7.24.0_3.txz
Installing curl-7.24.0_3...Installing ca_root_nss-3.14.3... done
 done
===>   Returning to build of ncmpcpp-0.5.10
===>   ncmpcpp-0.5.10 depends on shared library: iconv.3 - not found
===>    Verifying install for iconv.3 in /usr/ports/converters/libiconv
===>   Installing existing package /packages/All/libiconv-1.14_1.txz
Installing libiconv-1.14_1... done
===>   Returning to build of ncmpcpp-0.5.10
===>   ncmpcpp-0.5.10 depends on shared library: glib-2.0 - not found
===>    Verifying install for glib-2.0 in /usr/ports/devel/glib20
===>   Installing existing package /packages/All/glib-2.34.3.txz
Installing glib-2.34.3...Installing gettext-0.18.1.1_1... done
Installing libffi-3.0.13... done
Installing pcre-8.33... done
Installing python27-2.7.5_1... done

3. Build failes:
checking for langinfo.h... yes
checking for pkg-config... no
checking for libmpdclient... no
configure: error: libmpdclient >= 2.1 is required!

4. Take a look in config.log:
configure:15321: checking for pkg-config
configure:15354: result: no
configure:15389: checking for libmpdclient
configure:15449: result: no
configure:15451: error: libmpdclient >= 2.1 is required!

5. Search the test for libmpdclient in configure:
if test -n "$libmpdclient_CFLAGS"; then
    pkg_cv_libmpdclient_CFLAGS="$libmpdclient_CFLAGS"
 elif test -n "$PKG_CONFIG"; then
    if test -n "$PKG_CONFIG" && \
    { { $as_echo "$as_me:${as_lineno-$LINENO}: \$PKG_CONFIG --exists --print-errors \"libmpdclient >= 2.1\""; } >&5
  ($PKG_CONFIG --exists --print-errors "libmpdclient >= 2.1") 2>&5
  ac_status=$?
  $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
  test $ac_status = 0; }; then
  pkg_cv_libmpdclient_CFLAGS=`$PKG_CONFIG --cflags "libmpdclient >= 2.1" 2>/dev/null`
                      test "x$?" != "x0" && pkg_failed=yes
else
  pkg_failed=yes
fi

=> Without pkgconf the configure script is unable to find libmpdclient, the build failes. The problem can be solved by adding a build time dependency to pkgconf. Patch is attached.
>How-To-Repeat:
-
>Fix:
--- Makefile.orig	2013-06-19 09:30:30.128591410 +0200
+++ Makefile	2013-06-19 09:28:24.986589371 +0200
@@ -13,7 +13,7 @@
 LIB_DEPENDS=	mpdclient:${PORTSDIR}/audio/libmpdclient \
 		fftw3:${PORTSDIR}/math/fftw3
 
-USES=		iconv ncurses
+USES=		iconv ncurses pkgconfig:build
 USE_BZIP2=	yes
 GNU_CONFIGURE=	yes
 USE_GNOME=	glib20

>Release-Note:
>Audit-Trail:
>Unformatted: