ports/179665: php52-imap missing SSL support, won't compile (fix included)

[Adam McDougall]

>Number:         179665
>Category:       ports
>Synopsis:       php52-imap missing SSL support, won't compile (fix included)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 18 00:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Adam McDougall
>Release:        9.1-STABLE
>Organization:
>Environment:
FreeBSD build9 9.1-STABLE FreeBSD 9.1-STABLE #1 r250855M: Tue May 21 12:42:34 EDT 2013     root at build9:/usr/obj/usr/src/sys/BUILD9  amd64

>Description:
In r319990 lang/php52 was convert to new options framework.  The implementation of SSL support was turned into a positive option instead of ".if !defined(WITHOUT_SSL)" but the new option is never set or offered in make config.  

In contrast php53 port has:
.if ${PHP_MODNAME} == "imap"
OPTIONS_DEFINE= SSL
OPTIONS_DEFAULT=        SSL
LIB_DEPENDS+=   c-client4.9:${PORTSDIR}/mail/cclient

CONFIGURE_ARGS+=--with-imap=${LOCALBASE} \
                --with-pcre-dir=${LOCALBASE}
USE_OPENSSL=    yes
.endif

But lang/php52/Makefile.ext is missing the OPTIONS_... = SSL lines so compile fails in a different section.  It compiles when I add the two OPTIONS lines, not sure if pcre-dir is needed or desired.
>How-To-Repeat:
compile lang/php52-imap, note configure error (cclient has SSL support but php52-imap wasn't instructed to use SSL so configure fails)

checking for crypt in -lcrypt... yes
configure: error: This c-client library is built with SSL support.

      Add --with-imap-ssl to your configure line. Check config.log for details.
      
===>  Script "configure" failed unexpectedly.
Please report the problem to admin at lissyara.su [maintainer] and attach the
"/wrkdirs/usr/ports/mail/php52-imap/work/php-5.2.17/ext/imap/config.log"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** [do-configure] Error code 1

Stop in /usr/ports/mail/php52-imap.
>Fix:
Add OPTIONS_DEFINE=SSL and OPTIONS_DEFAULT=SSL to .if ${PHP_MODNAME} == "imap" in ports/lang/php52/Makefile.ext like ports/lang/php53/Makefile.ext

>Release-Note:
>Audit-Trail:
>Unformatted: