ports/180738: sysutils/bacula-server fix rcvar in bacula-sd rc.d scripts

[Oleg Ginzburg]

>Number:         180738
>Category:       ports
>Synopsis:       sysutils/bacula-server fix rcvar in bacula-sd rc.d scripts
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 22 16:00:03 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Oleg Ginzburg
>Release:        
>Organization:
>Environment:
>Description:
/usr/ports/sysutils/bacula-server/files/bacula-sd.in have wrong rcvar value. With current setting, fresh install of the bacula-server try to start sd without corresponding params in rc.conf:

# service bacula-sd start
/usr/local/etc/rc.d/bacula-sd: set_rcvar: not found
Starting bacula_sd.
22-Jul 19:49 bacula-sd: ERROR TERMINATION at parse_conf.c:918
Config error: Cannot open config file "/usr/local/etc/bacula/bacula-sd.conf": No such file or directory

/usr/local/etc/rc.d/bacula-sd: WARNING: failed to start bacula_sd

>How-To-Repeat:
make -C /usr/ports/sysutils/bacula-server install
service bacula-sd start


>Fix:
change to

rcvar=${name}_enable



Patch attached with submission follows:

diff -ruN bacula-server.bak/Makefile bacula-server/Makefile
--- bacula-server.bak/Makefile	2013-07-22 12:46:21.000000000 +0400
+++ bacula-server/Makefile	2013-07-22 19:56:15.000000000 +0400
@@ -3,7 +3,7 @@
 
 PORTNAME=	bacula
 DISTVERSION=	5.2.12
-PORTREVISION?=	2
+PORTREVISION?=	3
 CATEGORIES?=	sysutils
 MASTER_SITES=	SF/bacula/bacula/${PORTVERSION}
 PKGNAMEPREFIX?=	#
diff -ruN bacula-server.bak/files/bacula-sd.in bacula-server/files/bacula-sd.in
--- bacula-server.bak/files/bacula-sd.in	2013-07-22 12:46:21.000000000 +0400
+++ bacula-server/files/bacula-sd.in	2013-07-22 19:53:07.000000000 +0400
@@ -17,7 +17,7 @@
 . /etc/rc.subr
 
 name="bacula_sd"
-rcvar=`set_rcvar`
+rcvar=${name}_enable
 command=%%PREFIX%%/sbin/bacula-sd
 
 load_rc_config $name


>Release-Note:
>Audit-Trail:
>Unformatted: